fix(NODE-3982): only pass username to SSPI if password is set #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as ready for review -- TS confirmed that this fix works as expected. |
durran
approved these changes
Feb 10, 2022
dariakp
approved these changes
Feb 10, 2022
nbbeeken
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
On Windows, a password is required in order for the input credentials to be forwarded to SSPI.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
See https://jira.mongodb.org/browse/DRIVERS-2180 – Pending confirmation from TS, this resolves connectivity issues when only the username is passed to the MongoDB driver when connecting using kerberos. (mongosh test build with this patch available at https://s3.amazonaws.com/mciuploads/mongosh/5afb80349eab42e026c5c8219cf378c7933b0d66/mongosh-0.0.0-dev.0-win32-x64.zip)
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>