CSHARP-4357: Error if RewrapManyDataKey is called with masterKey and without provider (#1099)

Author: BorisDog

src/MongoDB.Driver/Encryption/RewrapManyDataKeyOptions.cs

@@ -37,7 +37,7 @@ public RewrapManyDataKeyOptions(
             string provider,
             Optional<BsonDocument> masterKey = default)
         {
-            _provider = Ensure.IsNotNull(provider, nameof(provider));
+            _provider = Ensure.IsNotNullOrEmpty(provider, nameof(provider));
             _masterKey = masterKey.WithDefault(null);
         }
 

tests/MongoDB.Driver.Tests/Specifications/client-side-encryption/prose-tests/ClientEncryptionProseTests.cs

@@ -30,7 +30,6 @@
 using FluentAssertions;
 using MongoDB.Bson;
 using MongoDB.Bson.TestHelpers.JsonDrivenTests;
-using MongoDB.TestHelpers.XunitExtensions;
 using MongoDB.Driver.Core;
 using MongoDB.Driver.Core.Authentication.External;
 using MongoDB.Driver.Core.Bindings;
@@ -44,6 +43,7 @@
 using MongoDB.Driver.Encryption;
 using MongoDB.Driver.TestHelpers;
 using MongoDB.Libmongocrypt;
+using MongoDB.TestHelpers.XunitExtensions;
 using Xunit;
 using Xunit.Abstractions;
 using Xunit.Sdk;
@@ -2272,6 +2272,29 @@ public void RewrapTest(
             }
         }
 
+        [Fact]
+        public void RewrapManyDataKeyOptions_ctor_should_validate_provider_is_set()
+        {
+            // rewrap prose test case 2
+            var exception = Record.Exception(() => new RewrapManyDataKeyOptions(null, new BsonDocument()));
+            exception.Should().BeOfType<ArgumentNullException>().Subject.ParamName.Should().Be("provider");
+
+            exception = Record.Exception(() => new RewrapManyDataKeyOptions("", new BsonDocument()));
+            exception.Should().BeOfType<ArgumentException>().Subject.ParamName.Should().Be("provider");
+        }
+
+        [Fact]
+        public void RewrapManyDataKeyOptions_with_should_validate_provider_is_set()
+        {
+            // rewrap prose test case 2
+            var subject = new RewrapManyDataKeyOptions("provider", new BsonDocument());
+            var exception = Record.Exception(() => subject.With(provider: null));
+            exception.Should().BeOfType<ArgumentNullException>().Subject.ParamName.Should().Be("provider");
+
+            exception = Record.Exception(() => subject.With(provider: ""));
+            exception.Should().BeOfType<ArgumentException>().Subject.ParamName.Should().Be("provider");
+        }
+
         [Theory]
         [ParameterAttributeData]
         public void ViewAreProhibitedTest([Values(false, true)] bool async)