Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup pre-commit hooks for the frontend #951

Open
khaledosman opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1161
Open

Setup pre-commit hooks for the frontend #951

khaledosman opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1161
Assignees
Labels
frontend local-dev local development

Comments

@khaledosman
Copy link
Contributor

Now that we have typescript, linting and code formatting setup for the frontend we should make sure all new code is compatible with the linting, type checking and formatting rules.

Once we add the CI for these actions we won't be able to merge code that's inconsistent with the setup rules, however instead of having to wait for the CI result its better if we run these tools and automatically fix any issues before pushing when creating a commit.

Some of the most standard/popular tools for setting this up on the frontend are lint-staged to only lint staged/edited files instead of the whole project and husky to setup the pre commit hooks

@khaledosman khaledosman added frontend local-dev local development labels Feb 20, 2025
@khaledosman khaledosman linked a pull request Mar 10, 2025 that will close this issue
4 tasks
@khaledosman khaledosman self-assigned this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend local-dev local development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant