Skip to content

Commit 0607093

Browse files
committed
chore(deps): Get audit-filter working for all packages in monorepo
* Add a lint:deps job to the top-level package.json, so lerna can run lint:deps in all packages in parallel. * Also handle recent handlebars vulnerability, so that builds don't fail. * Note, the lint:deps job is a no-op in fxa-amplitude-send, as I can't get it to build yet in the monorepo. Some of the vulnerabilities are in transitive dependencies, yet the suggested `npm update foo --depth N` command sometimes seems to do nothing. There was a related bug in npm 6.6.0 - 6.11.2, fixed by npm/cli#239, but perhaps that didn't fix all the cases? (I was using npm 6.12.0.) As a workaround, I've added audit-filter exceptions where `npm update` wasn't able to fix vulnerabilities. Fixes #2229.
1 parent 28b3857 commit 0607093

File tree

17 files changed

+2015
-1244
lines changed

17 files changed

+2015
-1244
lines changed

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"authors": "git shortlog -s | cut -c8- | sort -f > AUTHORS",
77
"postinstall": "_scripts/install_all.sh",
88
"npm-ci-all": "lerna exec --parallel -- npm ci",
9+
"lint:deps": "lerna exec --parallel -- npm run lint:deps",
910
"start": "pm2 start mysql_servers.json && echo \"Use 'npm stop' to stop all the servers\"",
1011
"stop": "pm2 kill",
1112
"start-firefox": "./packages/fxa-dev-launcher/bin/fxa-dev-launcher",

packages/fxa-amplitude-send/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
},
2222
"scripts": {
2323
"build-node-docker-image": "docker build -f Dockerfile-nodejs -t mozilla/fxa-amplitude-send:`git describe`-node .",
24-
"lint": "eslint *.js bin/*.js"
24+
"lint": "eslint *.js bin/*.js",
25+
"lint:deps": "echo 'dependency checking not yet enabled for fxa-amplitude-send'"
2526
},
2627
"repository": {
2728
"type": "git",

packages/fxa-auth-db-mysql/.nsprc

+14-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
11
{
2-
"exceptions": []
2+
"comment_755": "755 is prototype pollution in handlebars, used by nyc.",
3+
"comment_1065": "1065 is prototype pollution in lodash, used by nyc.",
4+
"comment_1164": "1164 is prototype pollution in handlebars, used by nyc.",
5+
"comment_1171": "1171 is RegExp denial of service in csv-parse, used by restify.",
6+
"comment_1300": "1300 is denial of service vulnerability in handlebars, used by nyc.",
7+
"comment_1316": "1316 is arbitrary code execution in handlebars, used by nyc.",
8+
"exceptions": [
9+
"https://npmjs.com/advisories/755",
10+
"https://npmjs.com/advisories/1065",
11+
"https://npmjs.com/advisories/1164",
12+
"https://npmjs.com/advisories/1171",
13+
"https://npmjs.com/advisories/1300",
14+
"https://npmjs.com/advisories/1316"
15+
]
316
}

0 commit comments

Comments
 (0)