Do not commit pretranslations with warnings (#3610)

mathjazz · web-flow · commit 7e357694ab2a · 2025-04-02T18:19:34.000+02:00
diff --git a/pontoon/sync/core/translations_to_repo.py b/pontoon/sync/core/translations_to_repo.py
@@ -215,7 +215,11 @@ def update_changed_resources(
                 locale__in=[locale.pk for locale in locales],
                 active=True,
             )
-            .filter(Q(approved=True) | Q(pretranslated=True) | Q(fuzzy=True))
+            .filter(
+                Q(approved=True)
+                | Q(pretranslated=True, warnings__isnull=True)
+                | Q(fuzzy=True)
+            )
             .exclude(approved_date__gt=now)  # includes approved_date = None
             .select_related("entity")
         )

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,11 @@ def update_changed_resources(`
`215`	`215`	`locale__in=[locale.pk for locale in locales],`
`216`	`216`	`active=True,`
`217`	`217`	`)`
`218`		`- .filter(Q(approved=True) \| Q(pretranslated=True) \| Q(fuzzy=True))`
	`218`	`+ .filter(`
	`219`	`+ Q(approved=True)`
	`220`	`+ \| Q(pretranslated=True, warnings__isnull=True)`
	`221`	`+ \| Q(fuzzy=True)`
	`222`	`+ )`
`219`	`223`	`.exclude(approved_date__gt=now) # includes approved_date = None`
`220`	`224`	`.select_related("entity")`
`221`	`225`	`)`