Add RevOrd type #10860
Closed
Add RevOrd type #10860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a limitless number of orderings you could want and we're not going to cover them all with traits. I think a newtype is the right choice in these cases, and we need a more powerful |
|
@thestinger Hmm, isn't the newtype you are asking for exactly what this pull request implements? |
|
@bill-myers: My comment had messed up wording. |
|
This is fine by me. Will bring up at the meeting. |
|
Consensus at the meeting was YAGNI. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
add checking for cfg(features = ...) *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`maybe_misused_cfg`]: check if `#[cfg(feature = "...")]` misused as `#[cfg(features = "...")]` I've found that there is no indication when `#[cfg(features = "...")]` is used incorrectly, which can easily make mistakes hard to spot. When I searched for this code on github, I also found many misuse cases([link](https://github.com/search?q=%23%5Bcfg%28features+language%3ARust&type=code)). PS: This clippy name is just a temporary name, it can be replaced with a better name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a RevOrd type in std::cmp, which reverses the natural order of types.
Such a type could be useful for implementing, for example, a max heap, assuming a min heap implementation already exists.