add el & update css in output_area to match run button in In from jupyter#3535

mpacer · mpacer · commit dd282f6970b9 · 2018-06-14T10:50:45.000-07:00
Without this change the output and Input areas become unaligned.

This still isn't an ideal fix, but it'll make a release possible without
making the styling problematic.
diff --git a/notebook/static/notebook/js/outputarea.js b/notebook/static/notebook/js/outputarea.js
@@ -370,6 +370,7 @@ define([
     OutputArea.prototype.create_output_area = function () {
         var oa = $("<div/>").addClass("output_area");
         if (this.prompt_area) {
+            oa.append($('<div/>').addClass('run_this_cell'));
             oa.append($('<div/>').addClass('prompt'));
         }
         return oa;
diff --git a/notebook/static/notebook/less/codecell.less b/notebook/static/notebook/less/codecell.less
@@ -42,7 +42,7 @@ div.code_cell div.input_prompt {
     min-width: 11ex;
 }
 
-div.code_cell:hover .run_this_cell {
+div.code_cell:hover div.input .run_this_cell {
     visibility: visible;
 }
 
@@ -70,4 +70,3 @@ div.input_area > div.highlight > pre {
     padding: 0px;
     background-color: transparent;
 }
-
diff --git a/notebook/static/notebook/less/outputarea.less b/notebook/static/notebook/less/outputarea.less
@@ -41,6 +41,7 @@ div.out_prompt_overlay:hover {
 
 div.output_prompt {
     color: @output_prompt_color;
+    min-width: 11ex;
 }
 
 /* This class is the outer container of all output sections. */

Original file line number	Diff line number	Diff line change
`@@ -370,6 +370,7 @@ define([`
`370`	`370`	`OutputArea.prototype.create_output_area = function () {`
`371`	`371`	`var oa = $("<div/>").addClass("output_area");`
`372`	`372`	`if (this.prompt_area) {`
	`373`	`+ oa.append($('<div/>').addClass('run_this_cell'));`
`373`	`374`	`oa.append($('<div/>').addClass('prompt'));`
`374`	`375`	`}`
`375`	`376`	`return oa;`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ div.code_cell div.input_prompt {`
`42`	`42`	`min-width: 11ex;`
`43`	`43`	`}`
`44`	`44`
`45`		`-div.code_cell:hover .run_this_cell {`
	`45`	`+div.code_cell:hover div.input .run_this_cell {`
`46`	`46`	`visibility: visible;`
`47`	`47`	`}`
`48`	`48`
`@@ -70,4 +70,3 @@ div.input_area > div.highlight > pre {`
`70`	`70`	`padding: 0px;`
`71`	`71`	`background-color: transparent;`
`72`	`72`	`}`
`73`		`-`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ div.out_prompt_overlay:hover {`
`41`	`41`
`42`	`42`	`div.output_prompt {`
`43`	`43`	`color: @output_prompt_color;`
	`44`	`+ min-width: 11ex;`
`44`	`45`	`}`
`45`	`46`
`46`	`47`	`/* This class is the outer container of all output sections. */`