Skip to content

Commit 4a2dd28

Browse files
authored
CI: replace apt-fast by apt-get + Nim v2.2.x in CI as Nim v2.0.10 is broken. (#473)
* CI: replace apt-fast by apt-get * CI: also test 2.2.x instead of 2.0.x due to #471 * docs: update README with compatible Nim versions
1 parent c5e88a9 commit 4a2dd28

File tree

2 files changed

+27
-24
lines changed

2 files changed

+27
-24
lines changed

.github/workflows/ci.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
fail-fast: false
88
max-parallel: 20
99
matrix:
10-
nim_version: [version-1-6, version-2-0]
10+
nim_version: [version-1-6, version-2-2] # version-2-0] is crashing due to https://github.com/mratsim/constantine/issues/471
1111
rust_toolchain: [stable] # [beta, nightly]
1212
go_toolchain: [stable]
1313
target:
@@ -158,7 +158,7 @@ jobs:
158158
- name: Install test dependencies (Linux amd64)
159159
if: runner.os == 'Linux' && matrix.target.cpu == 'amd64'
160160
run: |
161-
sudo DEBIAN_FRONTEND='noninteractive' apt-fast install \
161+
sudo DEBIAN_FRONTEND='noninteractive' apt-get install \
162162
--no-install-recommends -yq \
163163
libgmp-dev \
164164
llvm
@@ -168,12 +168,12 @@ jobs:
168168
# We don't install LLVM as the Rust libraries that call Constantine are 64-bit only.
169169
run: |
170170
sudo dpkg --add-architecture i386
171-
sudo apt-fast update -qq
171+
sudo apt-get update -qq
172172
173173
# Try to fix "E: Unable to correct problems, you have held broken packages."
174-
sudo apt-fast clean
174+
sudo apt-get clean
175175
176-
sudo DEBIAN_FRONTEND='noninteractive' apt-fast install \
176+
sudo DEBIAN_FRONTEND='noninteractive' apt-get install \
177177
--no-install-recommends -yq \
178178
gcc-multilib g++-multilib \
179179
libssl-dev:i386 libgmp-dev:i386

README.md

+22-19
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,24 @@ with a particular focus on cryptography used in blockchains and zero-knowledge p
1616
<!-- TOC -->
1717

1818
- [Constantine](#constantine)
19-
- [Public API: Curves & Protocols](#public-api-curves--protocols)
20-
- [Protocols](#protocols)
21-
- [Elliptic Curves](#elliptic-curves)
22-
- [General cryptography](#general-cryptography)
23-
- [Threadpool](#threadpool)
24-
- [Installation](#installation)
25-
- [From Rust](#from-rust)
26-
- [From Go](#from-go)
27-
- [From C](#from-c)
28-
- [From Nim](#from-nim)
29-
- [Dependencies & Requirements](#dependencies--requirements)
30-
- [Performance](#performance)
31-
- [Assembly & Hardware acceleration](#assembly--hardware-acceleration)
32-
- [Security](#security)
33-
- [Disclaimer](#disclaimer)
34-
- [Security disclosure](#security-disclosure)
35-
- [Why Nim](#why-nim)
36-
- [License](#license)
19+
- [Public API: Curves \& Protocols](#public-api-curves--protocols)
20+
- [Protocols](#protocols)
21+
- [Elliptic Curves](#elliptic-curves)
22+
- [General cryptography](#general-cryptography)
23+
- [Threadpool](#threadpool)
24+
- [Installation](#installation)
25+
- [From Rust](#from-rust)
26+
- [From Go](#from-go)
27+
- [From C](#from-c)
28+
- [From Nim](#from-nim)
29+
- [Dependencies \& Requirements](#dependencies--requirements)
30+
- [Performance](#performance)
31+
- [Assembly \& Hardware acceleration](#assembly--hardware-acceleration)
32+
- [Security](#security)
33+
- [Disclaimer](#disclaimer)
34+
- [Security disclosure](#security-disclosure)
35+
- [Why Nim](#why-nim)
36+
- [License](#license)
3737

3838
<!-- /TOC -->
3939
The library aims to be a fast, compact and hardened library for elliptic curve cryptography needs, in particular for blockchain protocols and zero-knowledge proofs system.
@@ -136,7 +136,10 @@ See the following documents on the threadpool performance details, design and re
136136
## Installation
137137

138138
> [!IMPORTANT]
139-
> Constantine can be compiled by Nim v1.6.x, v2.0.2 and v2.0.4 but not Nim v2.0.0 (due to a compile-time evaluation crash)
139+
> Constantine can be compiled with:
140+
> - Nim v1.6.x,
141+
> - Nim v2.0.2 to v2.0.8 but not Nim v2.0.0 and Nim 2.0.10 (due to compile-time evaluation crashes)
142+
> - Nim v2.2.0
140143
141144
### From Rust
142145

0 commit comments

Comments
 (0)