Skip to content

Commit e89e984

Browse files
committed
[ecdsa] remove hash from Eth ECDSA file, specific to Eth now
1 parent 4c6c799 commit e89e984

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

constantine/eth_ecdsa_signatures.nim

+6-9
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,19 @@ func signatures_are_equal*(a, b: Signature): bool {.libPrefix: prefix_ffi.} =
4747
proc sign*(sig: var Signature,
4848
secretKey: SecretKey,
4949
message: openArray[byte],
50-
nonceSampler: NonceSampler = nsRandom,
51-
H: type CryptoHash = sha256) {.libPrefix: prefix_ffi, genCharAPI.} =
50+
nonceSampler: NonceSampler = nsRandom) {.libPrefix: prefix_ffi, genCharAPI.} =
5251
## Sign `message` using `secretKey` and store the signature in `sig`. The nonce
5352
## will either be randomly sampled `nsRandom` or deterministically calculated according
5453
## to RFC6979 (`nsRfc6979`)
55-
sig.coreSign(secretKey.raw, message, H, nonceSampler)
54+
sig.coreSign(secretKey.raw, message, keccak256, nonceSampler)
5655

5756
proc verify*(
5857
publicKey: PublicKey,
5958
message: openArray[byte],
60-
signature: Signature,
61-
H: type CryptoHash = sha256
59+
signature: Signature
6260
): bool {.libPrefix: prefix_ffi, genCharAPI.} =
6361
## Verify `signature` using `publicKey` for `message`.
64-
result = publicKey.raw.coreVerify(message, signature, H)
62+
result = publicKey.raw.coreVerify(message, signature, keccak256)
6563

6664
func derive_pubkey*(public_key: var PublicKey, secret_key: SecretKey) {.libPrefix: prefix_ffi.} =
6765
## Derive the public key matching with a secret key
@@ -73,14 +71,13 @@ proc recoverPubkey*(
7371
publicKey: var PublicKey,
7472
message: openArray[byte],
7573
signature: Signature,
76-
evenY: bool,
77-
H: type CryptoHash = sha256
74+
evenY: bool
7875
) {.libPrefix: prefix_ffi, genCharAPI.} =
7976
## Verify `signature` using `publicKey` for `message`.
8077
##
8178
## `evenY == true` returns the public key corresponding to the
8279
## even `y` coordinate of the `R` point.
83-
publicKey.raw.recoverPubkey(signature, message, evenY, H)
80+
publicKey.raw.recoverPubkey(signature, message, evenY, keccak256)
8481

8582
proc recoverPubkey*(
8683
publicKey: var PublicKey,

0 commit comments

Comments
 (0)