New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AtomicFunctionNode: add inline support #30732

Open

sunag wants to merge 1 commit into mrdoob:dev from sunag:dev-atomic-rev

+16 −40

Collaborator

sunag commented Mar 13, 2025

Fixes: #30634

Description

Add inline support for a.assign(b) and removed the redundant .storeNode.

sunag added this to the r175 milestone


          add inline support

f480f35

github-actions bot commented Mar 13, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.02 78.26	336.02 78.26	+0 B +0 B
WebGPU	520.73 145.18	520.52 145.15	-200 B -29 B
WebGPU Nodes	520.19 145.07	519.99 145.04	-200 B -30 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.06 112.14	465.06 112.14	+0 B +0 B
WebGPU	591.12 160.82	591.01 160.79	-108 B -25 B
WebGPU Nodes	546.24 150.25	546.13 150.23	-108 B -26 B

sunag marked this pull request as ready for review

March 13, 2025 00:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet