Skip to content

Commit 702997c

Browse files
committed
Revert "url: significantly improve the performance of the url module"
This reverts commit 3fd7fc4. It was agreed that this change contained too much potential ecosystem breakage, particularly around the inability to `delete` properties off a `Url` object. It may be re-introduced for a later release, along with better work on ecosystem compatibility. PR-URL: nodejs#1602 Reviewed-By: Mikeal Rogers <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Forrest L Norvell <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Isaac Z. Schlueter <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
1 parent 0daed24 commit 702997c

File tree

6 files changed

+529
-2786
lines changed

6 files changed

+529
-2786
lines changed

lib/_http_client.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ function ClientRequest(options, cb) {
2020
OutgoingMessage.call(self);
2121

2222
if (typeof options === 'string') {
23-
options = url.parse(options).toJSON();
23+
options = url.parse(options);
2424
} else {
2525
options = util._extend({}, options);
2626
}

lib/https.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ exports.Agent = Agent;
107107

108108
exports.request = function(options, cb) {
109109
if (typeof options === 'string') {
110-
options = url.parse(options).toJSON();
110+
options = url.parse(options);
111111
} else {
112112
options = util._extend({}, options);
113113
}

0 commit comments

Comments
 (0)