chocolateyGH-405: fix edge case Get-PackageNamesFromInvocationLine

Author: mwallner

Boxstarter.Chocolatey/Chocolatey.ps1

@@ -364,10 +364,13 @@ function Get-PackageNamesFromInvocationLine {
             if ($namedParameters -contains $param) {
                 $skipNext = $true
             }
-            elseif ($param -contains '=') {
+            elseif ($param.IndexOf('=') -eq $param.Length - 1) {
                 $skipNext = $true
             }
         }
+        elseif ($a -eq '=') {
+            $skipNext = $true
+        }
         else {
             $packageNames += $a
         }

tests/Chocolatey/Chocolatey.tests.ps1

@@ -479,6 +479,18 @@ Describe "Get-PackageNamesFromInvocationLine" {
         $pkgNames = Get-PackageNamesFromInvocationLine @("-foo=bar", "pkg1", "-pkg2=???")
         $pkgNames | Should Be "pkg1"
     }
+    It "ignores any parameter that contains a '=' (weird case)" {
+        $pkgNames = Get-PackageNamesFromInvocationLine @("-foo", "=", "bar", "pkg1", "-pkg2=???")
+        $pkgNames | Should Be "pkg1"
+    }
+    It "ignores any parameter that contains a '=' (paranoid case)" {
+        $pkgNames = Get-PackageNamesFromInvocationLine @("-a=", "paranoid", "-foo", "=", "bar", "pkg1", "-pkg2=???")
+        $pkgNames | Should Be @("pkg1")
+    }
+    It "ignores any parameter that contains a '=' (paranoid case x paranoid case)" {
+        $pkgNames = Get-PackageNamesFromInvocationLine @("-a=", "paranoid", "-foo", "=", "bar", @("-a=paranoid"), "pkg1", @("-a", "=", "paranoid"), "-pkg2=???")
+        $pkgNames | Should Be @("pkg1")
+    }
 }
 
 Describe "Install-ChocolateyInstallPackageOverride" {