Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace createCredentials + createSecurePair with tls.connect #737

Closed
sidorares opened this issue Feb 21, 2014 · 2 comments
Closed

replace createCredentials + createSecurePair with tls.connect #737

sidorares opened this issue Feb 21, 2014 · 2 comments
Assignees
@sidorares

Comments

@sidorares
Copy link
Member

See 4b59612#commitcomment-5445205

createSecurePair is deprecated in v0.11.x. and should be replaced with tls.connect
@sidorares sidorares self-assigned this Feb 21, 2014
sidorares referenced this issue Feb 21, 2014
@sidorares
startTLS implementation
4b59612
@dougwilson
Copy link
Member

tls.connect does not allow peer certificate checking without hostname verification. I don't know any MySQL servers (even Amazon RDS) that have the correct hostname in their certificate.

@rogierschouten rogierschouten mentioned this issue Jul 22, 2015
Closed
@ChALkeR ChALkeR mentioned this issue Feb 26, 2017
Closed
@dougwilson
Copy link
Member

Replaced with tls.createSecureContext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sidorares sidorares

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @sidorares