Skip to content

Commit cb518c7

Browse files
committed
🐛 fix hasSideEffect false negative
1 parent aac472e commit cb518c7

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

docs/api/ast-utils.md

+1
Original file line numberDiff line numberDiff line change
@@ -363,6 +363,7 @@ The side effect means that it *may* modify a certain variable or object member.
363363
- `AssignmentExpression`
364364
- `AwaitExpression`
365365
- `CallExpression`
366+
- `ImportExpression`
366367
- `NewExpression`
367368
- `UnaryExpression` (`[operator = "delete"]`)
368369
- `UpdateExpression`

src/has-side-effect.js

+3
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ const visitor = Object.freeze(
8383
FunctionExpression() {
8484
return false
8585
},
86+
ImportExpression() {
87+
return true
88+
},
8689
MemberExpression(node, options, visitorKeys) {
8790
if (options.considerGetters) {
8891
return true

0 commit comments

Comments
 (0)