-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft OAuth2 Credentials don't accept expressions / external secrets #13888
Comments
Hey @erictmnz, We have created an internal ticket to look into this which we will be tracking as "GHC-1177" |
Hi @Joffcom , This is not causing any issues in the other ~25 credentials though - it's specifically this one that seems to not recognise it and perhaps it's not picking up expression vs fixed values in the fields. Because when the static value is entered as an expression it also fails. |
Hey @erictmnz Is it just that one credential or is it all oauth credentials? There was a similar issue in the past that impacted oauth credentials. I would also be wary of using secrets that are not officially supported as well, while it may work in some cases it is not a valid path in our implementation so you may see issues in the future. Quick edit: this is the PR that resolved this issue previously #13110 |
Hi @Joffcom, I just tested it and it does seem to be an issue with other OAuth credentials as well. Thanks - appreciate linking the PR as well - looks like a similar issue. |
Hey @erictmnz Was it the sales team or support team that recommended this just so I know where to check in the morning 🙂 It looks like the PR is included in the version you are on so the question then will be... do we also fix this for something we don't support or do we wait until we do support it to resolve it. For now the temporary option could be to try credential overwrites which would then hide the secret and client fields in the ui so you only need to worry about setting the scope. Ignore that it mentions embed this works on all versions: https://docs.n8n.io/embed/configuration/#credential-overwrites |
Hi @Joffcom, We were working through this with Marcus and Liam who seem to have consulted with other colleagues in the background. :) The credential overwrite looks like a possible workaround that we could potentially run from our CI/CD pipeline - although it does slow down adding secrets and complicates the setup with the pipeline step so probably not preferred. |
Describe the problem/error/question
When we add Microsoft Oauth2 Credentials and use fixed, hard coded client id and secret then the connection succeeds.
However, when we use expressions and/or external secrets then the credentials saves but the Oauth flow can't be completed.
Note, that with Azure KeyVault the dot notation is still defunct as well.
What is the error message (if any)?
Debug info
core
storage
pruning
client
Generated at: 2025-03-13T00:05:58.431Z}
The text was updated successfully, but these errors were encountered: