Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM exports #534

Closed
Gobd opened this issue Jan 12, 2025 · 4 comments
Closed

Add ESM exports #534

Gobd opened this issue Jan 12, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@Gobd
Copy link
Contributor

Gobd commented Jan 12, 2025

Here's an issue from jsonwebtoken for the same auth0/node-jsonwebtoken#655 I think it would be nice to do this here and maybe encourage people to switch to this library.

@dosubot dosubot bot added the enhancement New feature or request label Jan 12, 2025
@andolivieri-nf
Copy link
Contributor

hello @Gobd, is there any specific reason/issue to do so? Library should already work fine with ESM

@Gobd
Copy link
Contributor Author

Gobd commented Feb 12, 2025

I guess just supporting the latest standards. As time goes on more and more people will want everything to be ESM so might as well get going now.

@simoneb
Copy link
Member

simoneb commented Feb 13, 2025

@Gobd I get your point but CJS modules are entirely usable from ESM, so I'm wondering if there any specific scenario that you have in mind.

@Gobd Gobd closed this as completed Feb 14, 2025
@Gobd
Copy link
Contributor Author

Gobd commented Feb 14, 2025

Closing, congrats on defending against the future standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants