Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of system-installed third-party ECMAScript libraries #259

Closed
nedbat opened this issue Sep 9, 2013 · 4 comments
Closed

Allow use of system-installed third-party ECMAScript libraries #259

nedbat opened this issue Sep 9, 2013 · 4 comments
Labels
enhancement New feature or request html

Comments

@nedbat
Copy link
Owner

nedbat commented Sep 9, 2013

Originally reported by Ben Finney (Bitbucket: bignose, GitHub: bignose)


Please allow the generated HTML report to use the system-installed version of ECMAScript libraries, instead of the ones bundled in Coverage.

While bundling third-party libraries can be convenient for some users who don't have the libraries on their system, Coverage should prefer the system-installed version of these libraries if the user indicates they exist.

The third-party ECMAScript libraries currently bundled (as of Coverage 3.6):

  • jQuery
  • jquery-hotkeys
  • jquery-isonscreen
  • jquery-tablesorter

These are all packaged in Debian at least, and installing a different version of these libraries for use only with Coverage is sub-optimal on such a system.

Specifically, the generation of an HTML report should use the system-installed instance of the above libraries.


@nedbat
Copy link
Owner Author

nedbat commented Sep 9, 2013

Original comment by Ben Finney (Bitbucket: bignose, GitHub: bignose)


This is a Coverage code patch, proposed for use in Debian's ‘python-coverage’ package, version 3.6-1.

@nedbat
Copy link
Owner Author

nedbat commented Sep 9, 2013

Original comment by Ben Finney (Bitbucket: bignose, GitHub: bignose)


I'm open to discussing what configuration or installation hooks the user has to tell Coverage to use the system-installed libraries.

The patch used by Debian is only applicable where the system libraries exist, and are in a specific location, and there is no option needed to use the bundled libraries. Some more generally-useful solution is needed.

@nedbat
Copy link
Owner Author

nedbat commented Sep 28, 2013

Original comment by Ben Finney (Bitbucket: bignose, GitHub: bignose)


Updated patch fixing a bug in copying resource files.

@nedbat
Copy link
Owner Author

nedbat commented Sep 29, 2013

Completed (in a different way) in e41fd0a7204d (bb).

@nedbat nedbat closed this as completed Sep 29, 2013
@nedbat nedbat added minor enhancement New feature or request html labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request html
Projects
None yet
Development

No branches or pull requests

1 participant