Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update operator logic gt and lt to gte and lte #64

Closed
lvrfrc87 opened this issue Jun 15, 2022 · 0 comments · Fixed by #89
Closed

Update operator logic gt and lt to gte and lte #64

lvrfrc87 opened this issue Jun 15, 2022 · 0 comments · Fixed by #89
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: minor feature

Comments

@lvrfrc87
Copy link
Collaborator

lvrfrc87 commented Jun 15, 2022 •
edited
Loading

Based on discussion: https://github.com/networktocode-llc/netcompare/pull/63#discussion_r895696463

As it is now, operator check has grater than - gt and lower than - lt types. Would nice also to have greater or equal than - gte as well as lower or equal than - lte
@lvrfrc87 lvrfrc87 added status: accepted This issue has been accepted by the maintainers team for implementation type: minor feature labels Sep 22, 2022
@lvrfrc87 lvrfrc87 changed the title Update operatpr logic gt and lt to gte and lte Update operator logic gt and lt to gte and lte Sep 26, 2022
@lvrfrc87 lvrfrc87 mentioned this issue Sep 27, 2022
Merged
@lvrfrc87 lvrfrc87 mentioned this issue Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: minor feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement ge and le operator type networktocode/jdiff
1 participant
@lvrfrc87