feat(files): add command to automatically rename filenames #51608
Conversation
susnux
force-pushed
the
feat/sanitize-filenames-command
branch
2 times, most recently
from
4343ae9 to
0f0846f
Compare
susnux
requested review from
skjnldsv,
ArtificialOwl,
come-nc,
artonge,
icewind1991,
szaimen,
nfebe and
a team
as code owners
susnux
added
3. to review
susnux
added
the
pending documentation
| parent::configure(); | ||
|
|
||
| $this | ||
| ->setName('files:windows-compatible-filenames') |
There was a problem hiding this comment.
The name could be more self-explanatory :)
There was a problem hiding this comment.
do you have a suggestion? I think the name is already very verbose
There was a problem hiding this comment.
Is this windows only? Or is there other reasons to enable this?
If windows only: files:fix-invalid-windows-filenames
If more general: files:fix-invalid-filenames ?
There was a problem hiding this comment.
This is a different command. It is not about fixing but about enabling the WCF feature (windows compatible filenames).
This enforces windows compatible filenames (see also existing flag in files admin settings)
susnux
force-pushed
the
feat/sanitize-filenames-command
branch
from
0f0846f to
5f0e99a
Compare
|
Hello @susnux What do you think about a simulation-parameter? |
susnux
force-pushed
the
feat/sanitize-filenames-command
branch
from
d2481e2 to
1ec65e7
Compare
This is implemented using |
Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/sanitize-filenames-command
branch
from
1ec65e7 to
437349c
Compare
|
Can we please expose the sanitizeName method in OCP? By adding it directly to IFilenameValidator perhaps? This would be very useful for integration apps like integration_google, integration_dropbox etc |
Summary
Make it easier for admins to rename all files when e.g. enabling Windows compatibility (ref #44963 ).
Checklist