Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General suggestions about headers #388

Closed
oesteban opened this issue Mar 6, 2017 · 5 comments
Closed

General suggestions about headers #388

oesteban opened this issue Mar 6, 2017 · 5 comments
Milestone

Comments

@oesteban
Copy link
Member

oesteban commented Mar 6, 2017

I'm finding real difficulties with files presenting non-diagonal sform matrices, they oftentimes mislead ANTs' initializations.

Since these matrices are only useful for mapping the data back to the scanner coordinates, I suggest here removing these matrices at the very beginning of the workflow, replacing them by the diagonal matrix of zooms.

We can have a final step where we set back the sform matrix (if necessary). For instance, if we report the preprocessed EPI on the T1w space, we would calculate the sform matrix from the T1w that would correspond to the preprocessed EPI. If the EPI is exactly in the grid of the T1w, then we set the sform of the T1w.

Taking care of the headers would also include issues like #384.

@oesteban
Copy link
Member Author

oesteban commented Mar 6, 2017

I am currently doing this with this simple interface (please have a look if possible): https://github.com/poldracklab/fmriprep/blob/fieldmaps/fmriprep/interfaces/images.py#L254

Replaces the affine so that (0, 0, 0) [mm] falls in the center of the volume, and the matrix is diagonal.

@oesteban
Copy link
Member Author

oesteban commented Mar 7, 2017

Looking closely at: nipy/nipype#1868

@effigies
Copy link
Member

To be clear on this, by non-diagonal, do you mean oblique, or orthogonal but not RAS-oriented?

Do we have any existing datasets that are still affected by the issues you describe? Or was this resolved in working on the fieldmap workflows?

@oesteban
Copy link
Member Author

  • The problem is orthogonal but not RAS-oriented. Particularly when you plug into ANTs two different orientations. If both are the same it works even for not RAS-oriented.
  • Datasets: I think I had this problem with ds054, but not sure now.

I have to say that the Affine initialization we are doing now is really robust against this problem.

@effigies
Copy link
Member

Okay. I'd rather not scrap sforms unless we have no other option. Since the problem doesn't seem to be biting us at present, I'm going to close this for now, and we can reopen if it comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants