Skip to content

Commit da8da56

Browse files
committedSep 22, 2019
enh: return radians unless degrees=True
1 parent c92d560 commit da8da56

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed
 

‎nibabel/affines.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ def voxel_sizes(affine):
299299
return np.sqrt(np.sum(top_left ** 2, axis=0))
300300

301301

302-
def obliquity(affine):
302+
def obliquity(affine, degrees=False):
303303
r"""
304304
Estimate the obliquity an affine's axes represent, in degrees from plumb.
305305
@@ -309,4 +309,7 @@ def obliquity(affine):
309309
"""
310310
vs = voxel_sizes(affine)
311311
fig_merit = (affine[:-1, :-1] / vs[np.newaxis, ...]).max(axis=1).min()
312-
return abs(acos(fig_merit) * 180 / PI)
312+
radians = abs(acos(fig_merit))
313+
if not degrees:
314+
return radians
315+
return radians * 180 / PI

‎nibabel/tests/test_affines.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -187,4 +187,4 @@ def test_obliquity():
187187
R = from_matvec(euler2mat(x=0.09, y=0.001, z=0.001), [0.0, 0.0, 0.0])
188188
oblique = R.dot(aligned)
189189
assert_almost_equal(obliquity(aligned), 0.0)
190-
assert_almost_equal(obliquity(oblique), 5.1569948883)
190+
assert_almost_equal(obliquity(oblique, degrees=True), 5.1569948883)

0 commit comments

Comments
 (0)
Please sign in to comment.