Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this deno compatible? #53

Closed
jimmywarting opened this issue Jul 23, 2020 · 1 comment
Closed

Make this deno compatible? #53

jimmywarting opened this issue Jul 23, 2020 · 1 comment

Comments

@jimmywarting
Copy link
Contributor

I have recently been thinking how to make this Deno compatible...
two think need to happen then.

  1. have to change to es6 module so this can be imported into any Deno code using import statement.
  2. make node-stream a optional dependency
stream () {
  if (globalThis.ReadableStream?.from) {
    return ReadableStream.from(read(...))
  } else {
    import('stream').then(({Readable}) => Readable.from(read(...)))
  }
}
@jimmywarting
Copy link
Contributor Author

Deno already have Blob+File implementation but it don't have a byte sequence #40
Actually deno should change there code so it's similar to this package

Oh, and
3) we can't use Buffer either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant