fix: file become exists, emit change event

Author: fengmk2

index.js

@@ -48,6 +48,7 @@ proto.add = function (fullpath) {
       event: null,
       path: fullpath,
       stat: null,
+      errorMessage: null
     };
     this._checkPath(fullpath);
   }
@@ -72,8 +73,23 @@ proto._checkPath = function (fullpath) {
   let that = this;
   fs.lstat(fullpath, function (err, stat) {
     if (err) {
+      if (info.errorMessage === err.message) {
+        // ignore this error
+        return;
+      }
+      info.errorMessage = err.message;
       return that.emit('stat-error', err);
     }
+
+    if (info.errorMessage) {
+      // error gone, need to emit change
+      info.errorMessage = null;
+      info.stat = stat;
+      info.event = 'change';
+      that.emit('change', info);
+      return;
+    }
+
     if (!info.stat) {
       info.stat = stat;
       return;

test/changing.test.js

@@ -22,17 +22,25 @@ const changing = require('../');
 const fixtures = path.join(__dirname, 'fixtures');
 
 describe('changing.test.js', function () {
-  afterEach(function () {
+  function cleanup() {
     fs.writeFileSync(path.join(fixtures, 'foo.js'), 'bar\n');
-  });
+    try {
+      fs.unlinkSync(path.join(fixtures, '.tmpfile'));
+    } catch (_) {
+      // ignore error
+    }
+  }
+
+  beforeEach(cleanup);
+  afterEach(cleanup);
 
   it('should create watch without options', function () {
     var watcher = changing();
     watcher.close();
   });
 
   it('should watching fixtures/foo.js change', function (done) {
-    let watcher = changing({ interval: '1s' });
+    let watcher = changing({ interval: 500 });
     watcher.add(path.join(fixtures, 'foo.js'));
     watcher.add(path.join(fixtures, 'foo.js'));
     watcher.on('change', function (info) {
@@ -47,20 +55,51 @@ describe('changing.test.js', function () {
 
     setTimeout(function () {
       fs.writeFileSync(path.join(fixtures, 'foo.js'), 'bar update\n');
-    }, 1500);
+    }, 1000);
   });
 
   it('should got stat-error when watch filepath not exists', function (done) {
-    let watcher = changing({ interval: '1s' });
+    let watcher = changing({ interval: '100ms' });
     watcher.add(path.join(fixtures, 'foo.js-not-exists'));
     watcher.add(path.join(fixtures, 'foo.js-not-exists'));
     watcher.on('change', function () {
       throw new Error('should not run this');
     });
     watcher.on('stat-error', function (err) {
       assert.equal(err.code, 'ENOENT');
-      watcher.close();
-      done();
+      // and emit once
+      setTimeout(function () {
+        watcher.close();
+        done();
+      }, 200);
+    });
+  });
+
+  it('should watching fixtures/.tmpfile become exists', function (done) {
+    let watcher = changing({ interval: 100 });
+    watcher.add(path.join(fixtures, '.tmpfile'));
+    watcher.on('change', function (info) {
+      assert.equal(info.event, 'change');
+      assert.equal(info.path, path.join(fixtures, '.tmpfile'));
+      assert(info.stat);
+
+      setTimeout(function () {
+        // remove it and emit stat-error again
+        fs.unlinkSync(path.join(fixtures, '.tmpfile'));
+        watcher.on('stat-error', function (err) {
+          assert.equal(err.code, 'ENOENT');
+
+          // and emit once
+          setTimeout(function () {
+            watcher.close();
+            done();
+          }, 200);
+        });
+      }, 200);
     });
+
+    setTimeout(function () {
+      fs.writeFileSync(path.join(fixtures, '.tmpfile'), 'tmpfile update\n');
+    }, 200);
   });
 });