Skip to content

Commit 8fcbb34

Browse files
aduh95cjihrigmhdawsonapapirovskiTrott
authored
Vote on prefix-only core modules (#1206)
* Vote on `node:`-only core modules * vote from aduh95 * vote from cjihrig * vote from mhdawson * vote from apapirovski * vote from Rich Trott * vote from fhinkel * vote from RaisinTen * vote from targos * vote from gireeshpunathil * vote from Matteo Collina * vote from Richard Lau * vote from Beth Griggs * vote from gireeshpunathil * vote from Danielle Adams * Vote for test runner node prefix * vote from MylesBorins * close vote and aggregate results * add vote from joyeecheung Co-authored-by: Joyee Cheung <[email protected]> * close vote and aggregate results Co-authored-by: cjihrig <[email protected]> Co-authored-by: Michael Dawson <[email protected]> Co-authored-by: Anatoli Papirovski <[email protected]> Co-authored-by: Rich Trott <[email protected]> Co-authored-by: Franziska Hinkelmann <[email protected]> Co-authored-by: Darshan Sen <[email protected]> Co-authored-by: Michaël Zasso <[email protected]> Co-authored-by: Gireesh Punathil <[email protected]> Co-authored-by: Matteo Collina <[email protected]> Co-authored-by: Richard Lau <[email protected]> Co-authored-by: Beth Griggs <[email protected]> Co-authored-by: Danielle Adams <[email protected]> Co-authored-by: James M Snell <[email protected]> Co-authored-by: Myles Borins <[email protected]> Co-authored-by: Joyee Cheung <[email protected]>
1 parent 4e5f211 commit 8fcbb34

File tree

2 files changed

+180
-0
lines changed

2 files changed

+180
-0
lines changed

‎votes/2022-04-11-0.json

+155
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,155 @@
1+
{
2+
"description": "`node:`-only core modules and built-in test runner module",
3+
"outcome": {
4+
"winner(s)": [
5+
"Ship the test runner as `node:test` and `require('test')` loads from userland."
6+
]
7+
},
8+
"votes": {
9+
"joyeecheung": {
10+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
11+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
12+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 2,
13+
"Ship the test runner as `node:test` and `require('test')` throws.": 1,
14+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
15+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
16+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
17+
},
18+
"MylesBorins": {
19+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
20+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
21+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
22+
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
23+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
24+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
25+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
26+
},
27+
"danielleadams": {
28+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -1,
29+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
30+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
31+
"Ship the test runner as `node:test` and `require('test')` throws.": 2,
32+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 2,
33+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
34+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 3
35+
},
36+
"gireeshpunathil": {
37+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
38+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
39+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
40+
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
41+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
42+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
43+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
44+
},
45+
"jasnell": {
46+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
47+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -1,
48+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": -1,
49+
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
50+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
51+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -1,
52+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
53+
},
54+
"mcollina": {
55+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -100,
56+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -90,
57+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 100,
58+
"Ship the test runner as `node:test` and `require('test')` throws.": -80,
59+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
60+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -10,
61+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": -10
62+
},
63+
"BethGriggs": {
64+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
65+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 4,
66+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
67+
"Ship the test runner as `node:test` and `require('test')` throws.": 3,
68+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
69+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
70+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
71+
},
72+
"richardlau": {
73+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -1,
74+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 1,
75+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
76+
"Ship the test runner as `node:test` and `require('test')` throws.": 5,
77+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 10,
78+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 4,
79+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 7
80+
},
81+
"fhinkel": {
82+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
83+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
84+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
85+
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
86+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
87+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
88+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
89+
},
90+
"targos": {
91+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
92+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 3,
93+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
94+
"Ship the test runner as `node:test` and `require('test')` throws.": 2,
95+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 3,
96+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
97+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
98+
},
99+
"RaisinTen": {
100+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 6,
101+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 4,
102+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 7,
103+
"Ship the test runner as `node:test` and `require('test')` throws.": 3,
104+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 5,
105+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 2,
106+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
107+
},
108+
"Trott": {
109+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
110+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
111+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
112+
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
113+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1,
114+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 1,
115+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 1
116+
},
117+
"apapirovski": {
118+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
119+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 1,
120+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 5,
121+
"Ship the test runner as `node:test` and `require('test')` throws.": 3,
122+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 2,
123+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 6,
124+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 4
125+
},
126+
"cjihrig": {
127+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": -100000,
128+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": -5,
129+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 1,
130+
"Ship the test runner as `node:test` and `require('test')` throws.": -1,
131+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 1000000,
132+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": -50,
133+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": -100
134+
},
135+
"mhdawson": {
136+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 1,
137+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 2,
138+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 7,
139+
"Ship the test runner as `node:test` and `require('test')` throws.": 5,
140+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 3,
141+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 6,
142+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 4
143+
},
144+
"aduh95": {
145+
"Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).": 0,
146+
"Ship the test runner as `test` (also available as `node:test`, like other current core modules).": 0,
147+
"Ship the test runner as `node:test` and `require('test')` loads from userland.": 0,
148+
"Ship the test runner as `node:test` and `require('test')` throws.": 0,
149+
"Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).": 0,
150+
"Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.": 0,
151+
"Ship the test runner as `node:test_runner` and `require('test_runner')` throws.": 0
152+
}
153+
},
154+
"refs": ["https://github.com/nodejs/TSC/pull/1206"]
155+
}

‎votes/2022-04-11-1.json

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
{
2+
"description": "Ship the test runner as node:test and require('test') loads from userland.",
3+
"refs": ["https://github.com/nodejs/TSC/pull/1206#issuecomment-1096855085"],
4+
"outcome": "Yes",
5+
"votes": {
6+
"aduh95": 1,
7+
"richardlau": 1,
8+
"RaisinTen": 1,
9+
"apapirovski": 1,
10+
"mhdawson": 1,
11+
"BethGriggs": 1,
12+
"joyeecheung": 1,
13+
"mcollina": 1,
14+
"ChALkeR": 1,
15+
"cjihrig": -1,
16+
"jasnell": -1,
17+
"Trott": 0,
18+
"targos": 0,
19+
"gireeshpunathil": 0,
20+
"fhinkel": 0,
21+
"tniessen": 0,
22+
"BridgeAR": 0,
23+
"MylesBorins": 0
24+
}
25+
}

0 commit comments

Comments
 (0)