Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer juliangruber/node-core-test in the Node.js org #683

Closed
aduh95 opened this issue May 1, 2022 · 10 comments
Closed

Transfer juliangruber/node-core-test in the Node.js org #683

aduh95 opened this issue May 1, 2022 · 10 comments

Comments

@aduh95
Copy link
Contributor

aduh95 commented May 1, 2022

@Gozala offered in nodejs/TSC#1206 (comment) to hand over the test npm module to the Node.js org, I would like to suggest that we accept that generous offer, and publish a new semver major containing a polyfill for the actual node:test core module.

I'm suggesting we use juliangruber/node-core-test for this purpose: it passes all the same test as the core module, its implementation matches closely core's, and it's compatible with all supported Node.js versions (Node.js 14+). The current repo owner is @juliangruber, who gave me a 👍 when I suggested that idea in private conversation.

//cc @nodejs/tsc @nodejs/test_runner

@aduh95
Copy link
Contributor Author

aduh95 commented May 9, 2022

This have been open for more than seven days with no objections, and has been 👍ed by two TSC members, so it's approved!

@Gozala could you transfer the ownership of https://npm.im/test to nodejs-foundation please?
@juliangruber could you transfer your repo to the nodejs org please?

@aduh95
Copy link
Contributor Author

aduh95 commented May 15, 2022

The repo has been transfered to the nodejs org, I've added @nodejs/test_runner as maintainers.

We would need to have an Automation token added to the repo's secrets to allow publishing to the npm repository. @mhdawson is it something you can take of?

  1. Go to https://www.npmjs.com/settings/nodejs-foundation/tokens/new
  2. Enter the nodejs-foundation account's password
  3. Name: NPM_TOKEN secret to publish node-core-test ?
    Type: "Automation"
    Click "Generate Token"
  4. Copy the generated token (it starts with "npm_")
  5. Go to https://github.com/nodejs/node-core-test/settings/secrets/actions/new
  6. Name: NPM_TOKEN
    Value: the token you copied at 4.
    Click "Add secret"

@Gozala just checking in, any chance you can make the transfer on npm happen and let us know when it's done?

@mhdawson
Copy link
Member

@aduh95 done as requested above

@Gozala
Copy link

Gozala commented May 16, 2022

@Gozala just checking in, any chance you can make the transfer on npm happen and let us know when it's done?

I have send an invite to @nodejs-foundation

@mhdawson
Copy link
Member

@Gozala thanks, accepted it. @aduh95 is there something more than accepting the invitation that we need to do?

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 2, 2022

@mhdawson I just released test v3.0.0 on npm and it looks like it works as expected. Can you make sure @nodejs-foundation is the only user that can publish on this package? Once that's done, I think this issue can be closed :)

@mhdawson
Copy link
Member

Ok, the only maintainer on the test package in npm is now nodejs-foundation.

@mhdawson
Copy link
Member

@aduh95 I also notice that the publishing access setting specific to the package likely need to be updated. I assume updating to Require two-factor authentication or automation tokens should be ok

@mhdawson
Copy link
Member

@aduh95 I updated the requirement for publishing so you should probably test again if possible.

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 15, 2022

I've just released version 3.0.1 successfully, it looks like everything is setup correctly. Thanks a lot for your help Micheal!

@aduh95 aduh95 closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants