jenkins: e-mail notification on job completion

[mmarchini]

I've been looking into how to easily setup #746 so collaborators get notified when a job finishes. The easiest way is to notify by e-mail and let the collaborator opt-in when they want to be notified.

To accomplish that, we need to use Email-ext plugin, because Jenkins Mailer Plugin only notifies on failures (or success builds after failures).

I tested this in a separate job and it seems to be working. Collaborators will have another field to fill when they want to be notified:

The e-mail will look like this (we can improve the message in the future):

Steps to add this to node-test-pull-request:

Add a new paramenter NOTIFY_EMAILS

Add a new post-build action Editable Email Notification

• Set Project Recipient List to $NOTIFY_EMAILS
• Leave Project Reply To List empty

Advanced Editable Email Notification setting

• Remove all Triggers
• Add a new one
  • When: Always
  • Send to: Recipient List

If @nodejs/build is fine with this approach, I can make the changes to node-test-pull-request.

[mhdawson]

I assume it does not affect the existing notifications on failures. As long as that is the case +1 from me.

[mmarchini]

These settings shouldn't interfere with existing notifications.

[github-actions]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is remove or a comment is made.