-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test installers somehow #235
Comments
Also, I think this is something we can only really do on the CI accurately. |
Sounds like we'd want to perfect an uninstaller on each os for this to run smoothly. |
.. or using VMs or containers that are reset at the beginning of each run. |
@orangemocha that won't really solve the users problem which most likely tied to old stuff laying around. We should essentially test:
Then rinse&repeat for a multitude of versions. |
I see what you mean. I was suggesting that we would need to be able to reset things to a clean state because if any of those uninstalls failed it could affect subsequent tests and, even worse, subsequent runs. |
@nodejs/build @Fishrock123 Should this remain open? |
Closing as stale, but if anyone wants to take this up feel free to reopen. |
I dunno how exactly this would work, but it sure would be great.
See nodejs/node#3606 on issues changing even minimal installer stuff can create.
@pmuellr Linked this to me, maybe it could help verifing everything. at least on OS X: https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man8/installer.8.html
The text was updated successfully, but these errors were encountered: