-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access to new mac infra for @gdams #851
Comments
+1 for individual machines access. @gdams I believe you'd be welcome in the Build WG if you want to join, and keep access after this is done! Also ok with infra access, but please make sure to revoke access when the machines go live (by updating the password, if I'm not missing anything). We must be much more careful at this level. cc @rvagg @jbergstroem |
To be clear, @mhdawson your intention is to share the credentials on |
@joaocgreis thanks for that! I am hoping to help set this up and then help setup a KeyBox instance for SSH key management so being in the build WG would be great! |
@joaocgreis yes that is what I was thinking. But of course wanted to see if other people on the build WG thought that would be ok or not. If that is not ok then the fallback would be to just give him access to the machines themselves, but that will take more work as the firewall etc needs to be setup first. |
@mhdawson shall I create another issue for adding me to the build WG? That way everyone can vote |
@joaocgreis would you like to create the issue to add gdams to the build WG ? Otherwise I can go it, just thinking that's better than self nomination. |
I think if @gdams raises a PR to add himself to the README then that's fine (and people can use the PR reviews to comment). |
@mhdawson I'm ok with giving him only the macstadium password and reset it after he's done. About joining, I don't think self nomination is a problem because we'd have to analyse the issue in exactly the same way. I'd have been happy to do it though, but I see I'm too late. |
Seems like there are no objections but I'd feel more comfortable with at +1 from @jbergstroem or @rvagg as well. |
Whoops! Yes, sorry, I very approve. I don't know if it'll help but perhaps we should schedule another day where we work collaboratively on this? My fear is that this vSphere stuff is such obscure specialised knowledge that only one person on the team (or not even on the team in this case I guess) will be the holder of that knowledge. It'd be great if we knew that more than one person knew how to wrangle this stuff for the future. |
I've got a time set next week with @gdams to ramp him up on what's in place already, outline key next steps and give me the access needed to get started. At that point would be useful to have a working session if we can find a time everbody can make it. |
Yes, hooked him up maybe 2 weeks ago. I'll follow up with him tomorrow/Monday and then we can see were we are. |
I'm assuming this has concluded |
I think this should stay open until its complete and we have updated to revoke his access. |
@mhdawson can we close this? I have the same level of access via my build WG membership |
Yup, closing |
I'm trying to pull @gdams into help make progress on configuring our new mac infrastructure.
I'd at least like to get him access to the individual machines.
Broader access would be good and I'm thinking it might not be as much of a concern yet since the infra is not yet setup and being used in our builds. We could look at doing things like changing keys etc. after the setup is complete.
As per the regular requirements in https://github.com/nodejs/build/blob/master/doc/process/special_access_to_build_resources.md:
The text was updated successfully, but these errors were encountered: