Skip to content

Commit a4d143c

Browse files
committed
remove 50 char limit on title line per new project guidelines
1 parent 34fd98e commit a4d143c

File tree

5 files changed

+6
-55
lines changed

5 files changed

+6
-55
lines changed

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ $ core-validate-commit --list
2828
pr-url enforce PR-URL
2929
reviewers enforce having reviewers
3030
subsystem enforce subsystem validity
31-
title-length enforce max length of commit title
3231
```
3332

3433
## Test

lib/format-pretty.js

-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ module.exports = function formatPretty(context, msgs, validator, opts) {
4646
}
4747

4848
switch (ruleId) {
49-
case 'title-length':
5049
case 'line-length':
5150
console.log(formatLength(msg, opts))
5251
break

lib/format-tap.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ module.exports = function formatTap(t, context, msgs, validator) {
2222
function onFail(context, m, validator, t) {
2323
switch (m.id) {
2424
case 'line-length':
25-
case 'title-length':
2625
lengthFail(context, m, validator, t)
2726
break
2827
case 'subsystem':
@@ -35,17 +34,14 @@ function onFail(context, m, validator, t) {
3534
}
3635

3736
function lengthFail(context, m, validator, t) {
38-
const body = m.id === 'title-length'
39-
? context.title
40-
: context.body
4137
t.fail(`${m.id}: ${m.message}`, {
4238
found: m.string.length
4339
, compare: '<='
4440
, wanted: m.maxLength
4541
, at: {
4642
line: m.line || 0
4743
, column: m.column || 0
48-
, body: body
44+
, body: context.body
4945
}
5046
})
5147
}

lib/rules/title-length.js

-39
This file was deleted.

test/validator.js

+5-9
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ test('Validator - misc', (t) => {
122122

123123
test('Validator - real commits', (t) => {
124124
t.test('basic', (tt) => {
125-
tt.plan(18)
125+
tt.plan(12)
126126
const v = new Validator()
127127
// run against the output of git show --quiet
128128
// run against the output of github's get commit api request
@@ -139,9 +139,7 @@ test('Validator - real commits', (t) => {
139139
const filtered = msgs.filter((item) => {
140140
return item.level === 'fail'
141141
})
142-
tt.equal(filtered.length, 3, 'messages.length')
143-
tt.equal(filtered[0].level, 'fail')
144-
tt.equal(filtered[0].id, 'title-length')
142+
tt.equal(filtered.length, 0, 'messages.length')
145143
})
146144
})
147145

@@ -159,9 +157,7 @@ test('Validator - real commits', (t) => {
159157
const filtered = msgs.filter((item) => {
160158
return item.level === 'fail'
161159
})
162-
tt.equal(filtered.length, 1, 'messages.length')
163-
tt.equal(filtered[0].level, 'fail')
164-
tt.equal(filtered[0].id, 'title-length')
160+
tt.equal(filtered.length, 0, 'messages.length')
165161
tt.end()
166162
})
167163
})
@@ -180,11 +176,11 @@ test('Validator - real commits', (t) => {
180176
const filtered = msgs.filter((item) => {
181177
return item.level === 'fail'
182178
})
183-
tt.equal(filtered.length, 3, 'messages.length')
179+
tt.equal(filtered.length, 2, 'messages.length')
184180
const ids = filtered.map((item) => {
185181
return item.id
186182
})
187-
const exp = ['line-length', 'line-length', 'title-length']
183+
const exp = ['line-length', 'line-length']
188184
tt.deepEqual(ids.sort(), exp.sort(), 'message ids')
189185
tt.end()
190186
})

0 commit comments

Comments
 (0)