Skip to content

Commit ba50cbb

Browse files
refackjoyeecheung
authored andcommitted
warn for 50 < title <= 72 (#18)
* warn for 50 < title <= 72 * deps bump (tap 10.7 works better on Windows)
1 parent 235c8a3 commit ba50cbb

File tree

6 files changed

+3967
-14
lines changed

6 files changed

+3967
-14
lines changed

.travis.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
language: node_js
22
node_js:
3-
- "6"
3+
- "8"
4+
- "9"
45
sudo: false

lib/format-pretty.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,9 @@ function formatMessage(msg) {
7777
const m = msg.message
7878
const icon = msg.level === 'fail'
7979
? utils.X
80-
: utils.CHECK
80+
: msg.level === 'warn'
81+
? utils.WARN
82+
: utils.CHECK
8183
return ` ${icon} ${line} ${utils.rightPad(m, 40)} ${id}`
8284
}
8385

lib/rules/title-length.js

+18-2
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,37 @@ module.exports = {
1010
}
1111
, defaults: {
1212
length: 50
13+
, max_length: 72
1314
}
1415
, options: {
1516
length: 50
17+
, max_length: 72
1618
}
1719
, validate: (context, rule) => {
20+
const max = rule.options.max_length
21+
if (context.title.length > max) {
22+
context.report({
23+
id: id
24+
, message: `Title must be <= ${max} columns.`
25+
, string: context.title
26+
, maxLength: max
27+
, line: 0
28+
, column: max
29+
, level: 'fail'
30+
})
31+
return
32+
}
33+
1834
const len = rule.options.length
1935
if (context.title.length > len) {
2036
context.report({
2137
id: id
22-
, message: `Title must be <= ${len} columns.`
38+
, message: `Title should be <= ${len} columns.`
2339
, string: context.title
2440
, maxLength: len
2541
, line: 0
2642
, column: len
27-
, level: 'fail'
43+
, level: 'warn'
2844
})
2945
return
3046
}

0 commit comments

Comments
 (0)