Skip to content

Commit 0b788ec

Browse files
doc: add minutes for meeting jan 25, 2022
Fixes: #523 PR-URL: #524 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
1 parent be15fc4 commit 0b788ec

File tree

1 file changed

+56
-0
lines changed

1 file changed

+56
-0
lines changed

wg-meetings/2022-01-25.md

+56
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# Node.js Diagnostics WorkGroup Meeting 2022-01-25
2+
3+
## Links
4+
5+
* **Recording**: https://www.youtube.com/watch?v=qfJP3C3sGwI
6+
* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/523
7+
* **Minutes Google Doc**: https://docs.google.com/document/d/1vwNhdIsHfBj4AtoSSzBjsv89Hxgqbv7flTT2jrDMHmE/edit
8+
9+
## Present
10+
11+
* Diagnostics team: @nodejs/diagnostics
12+
* Rafael Gonzaga: @rafaelgss
13+
* Bradley Farias: @bmeck
14+
* Stephen Belanger: @qard
15+
* Gireesh Punathil: @gireeshpunathil
16+
* Tony Gorez: @tony-go
17+
18+
## Agenda
19+
20+
## Announcements
21+
22+
*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
23+
24+
### nodejs/diagnostics
25+
26+
* Add using clinic/heap-profiler step [#521](https://github.com/nodejs/diagnostics/issues/521)
27+
- rafael: the issue is opened to discuss possibility of recommending clinic/heap-profiler in our docs
28+
- gireesh: we have incorporated many third party tools in the past, so should not be an issue
29+
- bradley: license agreements in 3rd party tools is what makes it problematic.
30+
- third-party tool can be recommended only if it is open-source licensed (MIT).
31+
- all: agree.
32+
* Document async_hooks types purposes [#511](https://github.com/nodejs/diagnostics/issues/511)
33+
- rafael: some async_hook resource types are underdocumented / undocumented
34+
- bradley: properties are not supposed to be stable, and they can change types based on future changes. it is ok to document those, but needs some tests to make sure they are always in sync with the code changes.
35+
- stephen: personally prefer to be explicit in the doc about what the type of a resource is and what it can hold, in reality.
36+
- tony: is there a tool that synchronizes the code and the doc?
37+
- stephen: it is not practical; there could be more subjective things to add in the doc such as API contract versus an arbitrary type, so prefer manual updates.
38+
- rafael: going to update the issue, follow the suggestions, and remove from the agenda.
39+
40+
* meeting time, again [#507](https://github.com/nodejs/diagnostics/issues/507)
41+
- gireesh: bradley, pls update your preferences in doodle, we will visit it in the next meeting once all preferences are in place.
42+
43+
* User Journey tracking documentation [#502](https://github.com/nodejs/diagnostics/issues/502)
44+
- rafel: just an information on the tweet that we just realized. Tony is here because of that. the label can be removed and progress can be made on the documentation work.
45+
46+
* Identify async_hooks use cases beyond AsyncLocalStorage [#437](https://github.com/nodejs/diagnostics/issues/437)
47+
- stephen: there wasn't any movement on this, take off the agenda.
48+
49+
50+
## Q&A, Other
51+
52+
## Upcoming Meetings
53+
54+
* **Node.js Foundation Calendar**: <https://nodejs.org/calendar>
55+
56+
Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.

0 commit comments

Comments
 (0)