Skip to content

Commit 815f6cf

Browse files
chorrellchorrell
authored
Merge pull request #949 from LaurentGoderre/fix-travis-envvars
Fixed the Travis Env Var error message
2 parents 64f490d + dec4831 commit 815f6cf

File tree

3 files changed

+85
-70
lines changed

3 files changed

+85
-70
lines changed

‎.travis.yml

+74-56
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,13 @@ stages:
4242
jobs:
4343
allow_failures:
4444
- env:
45-
- TEST: Markdown link check
45+
- TEST=mardown_lint
4646

4747
include:
4848
- stage: Test
49+
name: Markdown link check
4950
env:
50-
- TEST: Markdown link check
51+
- TEST=mardown_lint
5152
language: node_js
5253
node_js:
5354
- lts/*
@@ -57,8 +58,7 @@ jobs:
5758
- find . -name "*.md" | xargs -n 1 markdown-link-check
5859

5960
- stage: Test
60-
env:
61-
- TEST: Editor Config check
61+
name: Editor Config check
6262
language: node_js
6363
node_js:
6464
- lts/*
@@ -68,8 +68,7 @@ jobs:
6868
- eclint check
6969

7070
- stage: Test
71-
env:
72-
- TEST: Doc Toc Check
71+
name: Doc Toc Check
7372
language: node_js
7473
node_js:
7574
- lts/*
@@ -80,21 +79,18 @@ jobs:
8079
diff -q README.md README.md.tmp
8180

8281
- stage: Test
83-
env:
84-
- TEST: shfmt check
82+
name: shfmt check
8583
script:
8684
- docker run -it --rm -v "$(pwd)":/sh -w /sh peterdavehello/shfmt:2.6.1 shfmt -sr -i 2 -l -w -ci .
8785
- git diff --color
8886
- git diff --stat=220 --color --exit-code
8987

9088
- stage: Test
91-
env:
92-
- TEST: Shell Check
89+
name: Shell Check
9390
script: shellcheck *.sh
9491

9592
- stage: Test
96-
env:
97-
- TEST: .travis.yml and travis.yml.template consistency
93+
name: .travis.yml and travis.yml.template consistency
9894
script:
9995
- ./update.sh
10096
- git diff --stat --exit-code .travis.yml
@@ -106,132 +102,154 @@ jobs:
106102

107103
- stage: Build
108104
before_script: *auto_skip
105+
name: 10 on jessie
109106
env:
110-
- NODE_VERSION: "10"
111-
- VARIANT: "jessie"
107+
- NODE_VERSION="10"
108+
- VARIANT="jessie"
112109

113110
- stage: Build
114111
before_script: *auto_skip
112+
name: 10 on jessie-slim
115113
env:
116-
- NODE_VERSION: "10"
117-
- VARIANT: "jessie-slim"
114+
- NODE_VERSION="10"
115+
- VARIANT="jessie-slim"
118116

119117
- stage: Build
120118
before_script: *auto_skip
119+
name: 10 on alpine
121120
env:
122-
- NODE_VERSION: "10"
123-
- VARIANT: "alpine"
121+
- NODE_VERSION="10"
122+
- VARIANT="alpine"
124123

125124
- stage: Build
126125
before_script: *auto_skip
126+
name: 10 on stretch
127127
env:
128-
- NODE_VERSION: "10"
129-
- VARIANT: "stretch"
128+
- NODE_VERSION="10"
129+
- VARIANT="stretch"
130130

131131
- stage: Build
132132
before_script: *auto_skip
133+
name: 10 on stretch-slim
133134
env:
134-
- NODE_VERSION: "10"
135-
- VARIANT: "stretch-slim"
135+
- NODE_VERSION="10"
136+
- VARIANT="stretch-slim"
136137

137138
- stage: Build
138139
before_script: *auto_skip
140+
name: 11 on alpine
139141
env:
140-
- NODE_VERSION: "11"
141-
- VARIANT: "alpine"
142+
- NODE_VERSION="11"
143+
- VARIANT="alpine"
142144

143145
- stage: Build
144146
before_script: *auto_skip
147+
name: 11 on stretch
145148
env:
146-
- NODE_VERSION: "11"
147-
- VARIANT: "stretch"
149+
- NODE_VERSION="11"
150+
- VARIANT="stretch"
148151

149152
- stage: Build
150153
before_script: *auto_skip
154+
name: 11 on stretch-slim
151155
env:
152-
- NODE_VERSION: "11"
153-
- VARIANT: "stretch-slim"
156+
- NODE_VERSION="11"
157+
- VARIANT="stretch-slim"
154158

155159
- stage: Build
156160
before_script: *auto_skip
161+
name: 6 on jessie
157162
env:
158-
- NODE_VERSION: "6"
159-
- VARIANT: "jessie"
163+
- NODE_VERSION="6"
164+
- VARIANT="jessie"
160165

161166
- stage: Build
162167
before_script: *auto_skip
168+
name: 6 on jessie-slim
163169
env:
164-
- NODE_VERSION: "6"
165-
- VARIANT: "jessie-slim"
170+
- NODE_VERSION="6"
171+
- VARIANT="jessie-slim"
166172

167173
- stage: Build
168174
before_script: *auto_skip
175+
name: 6 on alpine
169176
env:
170-
- NODE_VERSION: "6"
171-
- VARIANT: "alpine"
177+
- NODE_VERSION="6"
178+
- VARIANT="alpine"
172179

173180
- stage: Build
174181
before_script: *auto_skip
182+
name: 6 on onbuild
175183
env:
176-
- NODE_VERSION: "6"
177-
- VARIANT: "onbuild"
184+
- NODE_VERSION="6"
185+
- VARIANT="onbuild"
178186

179187
- stage: Build
180188
before_script: *auto_skip
189+
name: 6 on stretch
181190
env:
182-
- NODE_VERSION: "6"
183-
- VARIANT: "stretch"
191+
- NODE_VERSION="6"
192+
- VARIANT="stretch"
184193

185194
- stage: Build
186195
before_script: *auto_skip
196+
name: 6 on stretch-slim
187197
env:
188-
- NODE_VERSION: "6"
189-
- VARIANT: "stretch-slim"
198+
- NODE_VERSION="6"
199+
- VARIANT="stretch-slim"
190200

191201
- stage: Build
192202
before_script: *auto_skip
203+
name: 8 on jessie
193204
env:
194-
- NODE_VERSION: "8"
195-
- VARIANT: "jessie"
205+
- NODE_VERSION="8"
206+
- VARIANT="jessie"
196207

197208
- stage: Build
198209
before_script: *auto_skip
210+
name: 8 on jessie-slim
199211
env:
200-
- NODE_VERSION: "8"
201-
- VARIANT: "jessie-slim"
212+
- NODE_VERSION="8"
213+
- VARIANT="jessie-slim"
202214

203215
- stage: Build
204216
before_script: *auto_skip
217+
name: 8 on alpine
205218
env:
206-
- NODE_VERSION: "8"
207-
- VARIANT: "alpine"
219+
- NODE_VERSION="8"
220+
- VARIANT="alpine"
208221

209222
- stage: Build
210223
before_script: *auto_skip
224+
name: 8 on onbuild
211225
env:
212-
- NODE_VERSION: "8"
213-
- VARIANT: "onbuild"
226+
- NODE_VERSION="8"
227+
- VARIANT="onbuild"
214228

215229
- stage: Build
216230
before_script: *auto_skip
231+
name: 8 on stretch
217232
env:
218-
- NODE_VERSION: "8"
219-
- VARIANT: "stretch"
233+
- NODE_VERSION="8"
234+
- VARIANT="stretch"
220235

221236
- stage: Build
222237
before_script: *auto_skip
238+
name: 8 on stretch-slim
223239
env:
224-
- NODE_VERSION: "8"
225-
- VARIANT: "stretch-slim"
240+
- NODE_VERSION="8"
241+
- VARIANT="stretch-slim"
226242

227243
- stage: Build
228244
before_script: *auto_skip
245+
name: chakracore/10 on default
229246
env:
230-
- NODE_VERSION: "chakracore/10"
231-
- VARIANT: "default"
247+
- NODE_VERSION="chakracore/10"
248+
- VARIANT="default"
232249

233250
- stage: Build
234251
before_script: *auto_skip
252+
name: chakracore/8 on default
235253
env:
236-
- NODE_VERSION: "chakracore/8"
237-
- VARIANT: "default"
254+
- NODE_VERSION="chakracore/8"
255+
- VARIANT="default"

‎travis.yml.template

+8-12
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,13 @@ stages:
4040
jobs:
4141
allow_failures:
4242
- env:
43-
- TEST: Markdown link check
43+
- TEST=mardown_lint
4444

4545
include:
4646
- stage: Test
47+
name: Markdown link check
4748
env:
48-
- TEST: Markdown link check
49+
- TEST=mardown_lint
4950
language: node_js
5051
node_js:
5152
- lts/*
@@ -55,8 +56,7 @@ jobs:
5556
- find . -name "*.md" | xargs -n 1 markdown-link-check
5657

5758
- stage: Test
58-
env:
59-
- TEST: Editor Config check
59+
name: Editor Config check
6060
language: node_js
6161
node_js:
6262
- lts/*
@@ -66,8 +66,7 @@ jobs:
6666
- eclint check
6767

6868
- stage: Test
69-
env:
70-
- TEST: Doc Toc Check
69+
name: Doc Toc Check
7170
language: node_js
7271
node_js:
7372
- lts/*
@@ -78,21 +77,18 @@ jobs:
7877
diff -q README.md README.md.tmp
7978

8079
- stage: Test
81-
env:
82-
- TEST: shfmt check
80+
name: shfmt check
8381
script:
8482
- docker run -it --rm -v "$(pwd)":/sh -w /sh peterdavehello/shfmt:2.6.1 shfmt -sr -i 2 -l -w -ci .
8583
- git diff --color
8684
- git diff --stat=220 --color --exit-code
8785

8886
- stage: Test
89-
env:
90-
- TEST: Shell Check
87+
name: Shell Check
9188
script: shellcheck *.sh
9289

9390
- stage: Test
94-
env:
95-
- TEST: .travis.yml and travis.yml.template consistency
91+
name: .travis.yml and travis.yml.template consistency
9692
script:
9793
- ./update.sh
9894
- git diff --stat --exit-code .travis.yml

‎update.sh

+3-2
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,10 @@ function add_stage() {
193193
echo '
194194
- stage: Build
195195
before_script: *auto_skip
196+
name: '"${version}"' on '"${variant}"'
196197
env:
197-
- NODE_VERSION: "'"${version}"'"
198-
- VARIANT: "'"${variant}"'"' >> .travis.yml
198+
- NODE_VERSION="'"${version}"'"
199+
- VARIANT="'"${variant}"'"' >> .travis.yml
199200
}
200201

201202
echo '# DO NOT MODIFY. THIS FILE IS AUTOGENERATED #

0 commit comments

Comments
 (0)