Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to join docker team? #444

Closed
PeterDaveHello opened this issue Jul 4, 2017 · 11 comments
Closed

How to join docker team? #444

PeterDaveHello opened this issue Jul 4, 2017 · 11 comments

Comments

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Jul 4, 2017

Hi, I'm already a member of nodejs organization, and a contributor of docker-node project, I wonder how can I join this docker team? Thanks.

@Starefossen
Copy link
Member

Could someone on the @nodejs/tsc add me or @chorrell as a team maintainer for the @nodejs/docker team. We still have members of that have not yet been added properly to the team.

@cjihrig
Copy link

cjihrig commented Jul 4, 2017

@Starefossen I've made you a maintainer.

@PeterDaveHello
Copy link
Member Author

So is there any reference about how people can get involved?

@SimenB
Copy link
Member

SimenB commented Jul 4, 2017

I still haven't gotten access either, #414

@SimenB
Copy link
Member

SimenB commented Jul 4, 2017

And kinda related when this lands, is there any need to go through PRs for patch releases of node?

@Starefossen
Copy link
Member

Starefossen commented Jul 4, 2017

@cjihrig (Colin Ihrig)
@Starefossen I've made you a maintainer.

Many thanks! Apparently I can not add team members which are outside of the organisation, would you mind hadding @SimenB to the org, or is there any other way he can join the org?

PeterDaveHello (Peter Dave Hello)
So is there any reference about how people can get involved?

Yes, both GOVERNANCE.md and CONTRIBUTING.md should cover that.

SimenB (Simen Bekkhus)
I still haven't gotten access either, #414

Apparently you need to be a member of the Node.js origination on GitHub before I can add you to the team.

SimenB (Simen Bekkhus)
And kinda related when this lands, is there any need to go through PRs for patch releases of node?

No, the master branch for this repo is restricted from directly being pushed to without going through a PR (or technically it is the CI verification that is the restriction). However, I would like to propose a change that such PRs can be self merged directly without waiting for other team members review.

@cjihrig
Copy link

cjihrig commented Jul 5, 2017

Accepted @PeterDaveHello and sent an invite to @SimenB

@PeterDaveHello
Copy link
Member Author

Thanks all.

@Starefossen
Copy link
Member

@PeterDaveHello please also make a Pull Reguest to add yourself properly to the collaborators list in README!

@PeterDaveHello
Copy link
Member Author

@Starefossen sure thing! Thanks for reminding!

@PeterDaveHello
Copy link
Member Author

Done #445 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants