Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to build Node.js binary with FIPS-compliant OpenSSL? #753

Closed
raydenx opened this issue Jul 26, 2017 · 8 comments
Closed

How to build Node.js binary with FIPS-compliant OpenSSL? #753

raydenx opened this issue Jul 26, 2017 · 8 comments

Comments

@raydenx
Copy link

raydenx commented Jul 26, 2017

  • Node.js Version: v6.11.1
  • OS: 3.8.13-118.13.3.el6uek.x86_64
  • Scope (install, code, runtime, meta, other?): install
  • Module (and version) (if relevant):

Is it possible to build Node.js binary with FIPS support and install it on another machine?
I followed steps provided at https://github.com/nodejs/node/blob/master/BUILDING.md#building-nodejs-with-fips-compliant-openssl

These steps are working fine for me. But this will install node on the machine where it's being built.

Running

CONFIG_FLAGS="--openssl-fips=/usr/local/ssl/fips-2.0" make -j4 binary

after following steps listed at https://github.com/nodejs/node/blob/master/BUILDING.md#building-nodejs-with-fips-compliant-openssl seems to take care of building binary that can be installed on another compatible machine, but I want to make sure I'm not missing something here.
Thanks.

@addaleax
Copy link
Member

/cc @nodejs/crypto

@sam-github
Copy link

I don't understand the question, you seem to have said everything worked, but you are wondering if you did it right?

Not sure why you used CONFIG_FLAGS= instead of ./configure ...

@raydenx
Copy link
Author

raydenx commented Jul 26, 2017

Yes, I am wondering if I did it right.
binary target executes ./configure without openssl-fips option. That's why I used CONFIG_FLAGS

@gireeshpunathil
Copy link
Member

@raydenx - is your issue still outstanding, or is it resolved? please let me know.

@raydenx
Copy link
Author

raydenx commented Mar 13, 2018

CONFIG_FLAGS="--openssl-fips=/usr/local/ssl/fips-2.0" make -j4 binary
worked for me. Noone really confirmed it is the right command but I will just assume yes.

@gireeshpunathil
Copy link
Member

/cc @mhdawson for confirmation.

@gireeshpunathil
Copy link
Member

./configure --help has this section:

--openssl-fips=OPENSSL_FIPS
                        Build OpenSSL using FIPS canister .o file in supplied folder

So either your way or ./configure --openssl-fips=/usr/local/ssl/fips-2.0 should work.

Hope this helps.

@gireeshpunathil
Copy link
Member

closing as answered, please let me know if this is outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants