Skip to content

Commit 45a2046

Browse files
fhembergercjihrig
authored andcommitted
installer: fix installers for node.js rename
This commit completes the io.js to Node.js rename in the Windows installer. Fixes: #2418 PR-URL: #2367 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
1 parent a69ab27 commit 45a2046

9 files changed

+5
-47
lines changed

doc/full-white-stripe.jpg

-6.37 KB
Loading

doc/osx_installer_logo.png

12.1 KB
Loading

doc/thin-white-stripe.jpg

-1.94 KB
Loading

src/res/node.ico

74.6 KB
Binary file not shown.

tools/install.py

-11
Original file line numberDiff line numberDiff line change
@@ -132,17 +132,6 @@ def files(action):
132132
exeext = '.exe' if is_windows else ''
133133
action(['out/Release/node' + exeext], 'bin/node' + exeext)
134134

135-
if not is_windows:
136-
# Install iojs -> node compatibility symlink.
137-
link_target = 'bin/node'
138-
link_path = abspath(install_path, link_target)
139-
if action == uninstall:
140-
action([link_path], link_target)
141-
elif action == install:
142-
try_symlink('iojs', link_path)
143-
else:
144-
assert(0) # Unhandled action type.
145-
146135
if 'true' == variables.get('node_use_dtrace'):
147136
action(['out/Release/node.d'], 'lib/dtrace/node.d')
148137

tools/msvs/msi/i18n/de-de.wxl

-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
<String Id="NodeRuntime_Title">Node.js-Laufzeitumgebung</String>
1313
<String Id="NodeRuntime_Description">Installation der [ProductName]-Laufzeitumgebung (node.exe).</String>
1414

15-
<String Id="NodeAlias_Title">Verweis von node auf iojs</String>
16-
<String Id="NodeAlias_Description">Erstelle node.exe als Verweis für iojs.exe.</String>
17-
1815
<String Id="NodePerfCtrSupport_Title">Performance Counter</String>
1916
<String Id="NodePerfCtrSupport_Description">Installiert Unterstützung für [ProductName]-spezifische Performance Counter.</String>
2017

tools/msvs/msi/i18n/en-us.wxl

-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
<String Id="NodeRuntime_Title">Node.js runtime</String>
1313
<String Id="NodeRuntime_Description">Install the core [ProductName] runtime (node.exe).</String>
1414

15-
<String Id="NodeAlias_Title">Alias node to iojs</String>
16-
<String Id="NodeAlias_Description">Create node.exe as an alias for iojs.exe.</String>
17-
1815
<String Id="NodePerfCtrSupport_Title">Performance counters</String>
1916
<String Id="NodePerfCtrSupport_Description">Installs support for [ProductName]-specific performance counters.</String>
2017

tools/msvs/msi/product.wxs

-23
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,6 @@
4949
<ComponentRef Id="AppData" />
5050
<ComponentGroupRef Id="Product.Generated"/>
5151

52-
<Feature Id="NodeAlias"
53-
Level="1"
54-
Title="!(loc.NodeAlias_Title)"
55-
Description="!(loc.NodeAlias_Description)">
56-
<ComponentRef Id="NodeAlias"/>
57-
</Feature>
58-
5952
<Feature Id="NodePerfCtrSupport"
6053
Level="1"
6154
Title="!(loc.NodePerfCtrSupport_Title)"
@@ -124,12 +117,6 @@
124117
<File Id="node.exe" KeyPath="yes" Source="$(var.SourceDir)\node.exe"/>
125118
</Component>
126119

127-
<Component Id="NodeAlias" Guid="fde09cce-a503-4409-a3c4-61ae2a5a5906">
128-
<!-- Always remove node.exe. The hard link will be recreated by the
129-
`LinkNodeExeToIojsExe` custom action whenever needed. -->
130-
<RemoveFile Id="node.exe" Name="node.exe" On="both" />
131-
</Component>
132-
133120
<Component Id="NodeVarsScript">
134121
<File Id="nodevars.bat" KeyPath="yes" Source="$(var.RepoDir)\tools\msvs\nodevars.bat"/>
135122
</Component>
@@ -262,13 +249,6 @@
262249
</Component>
263250
</DirectoryRef>
264251

265-
<CustomAction Id="LinkNodeExeToIojsExe"
266-
FileKey="iojs.exe"
267-
ExeCommand="-e &quot; require('fs').linkSync(process.execPath, require('path').resolve(process.execPath, '../node.exe')); &quot;"
268-
Impersonate="no"
269-
Execute="deferred"
270-
Return="check" />
271-
272252
<Binary Id='BroadcastEnvironmentUpdate'
273253
SourceFile='$(var.custom_actions.TargetDir)$(var.custom_actions.TargetName).dll' />
274254

@@ -279,9 +259,6 @@
279259
Return="check" />
280260

281261
<InstallExecuteSequence>
282-
<Custom Action="LinkNodeExeToIojsExe" After="InstallFiles">
283-
$NodeAlias = 3
284-
</Custom>
285262
<Custom Action='BroadcastEnvironmentUpdate' After='InstallFinalize'/>
286263
</InstallExecuteSequence>
287264

tools/osx-pkg.pmdoc/index.xml.tmpl

+5-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<pkmkdoc spec="1.12">
22
<properties>
33
<title>Node.js</title>
4-
<build>/Users/iojs/Desktop/iojs.pkg</build>
5-
<organization>org.iojs</organization>
4+
<build>/Users/nodejs/Desktop/node.pkg</build>
5+
<organization>org.nodejs</organization>
66
<userSees ui="both"/>
77
<min-target os="3"/>
88
<domain system="true"/>
@@ -13,10 +13,10 @@
1313
</distribution>
1414
<contents>
1515
<choice title="Node.js" id="choice1" starts_selected="true" starts_enabled="true" starts_hidden="false">
16-
<pkgref id="org.iojs.iojs.pkg"/>
16+
<pkgref id="org.nodejs.pkg"/>
1717
</choice>
1818
<choice title="npm" id="choice2" starts_selected="true" starts_enabled="true" starts_hidden="false">
19-
<pkgref id="org.iojs.npm.pkg"/>
19+
<pkgref id="org.nodejs.node.npm.pkg"/>
2020
</choice>
2121
</contents>
2222
<resources bg-scale="none" bg-align="topleft">
@@ -28,16 +28,14 @@
2828
{\colortbl;\red255\green255\blue255;}
2929
\pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\ql\qnatural\pardirnatural
3030

31-
\f0\fs26 \cf0 This package will install Node.js {iojsversion} and npm {npmversion} into /usr/local/. The binary /usr/local/bin/iojs will also be symlinked as /usr/local/bin/node.}]]></resource>
31+
\f0\fs26 \cf0 This package will install Node.js {nodeversion} and npm {npmversion} into /usr/local/.}]]></resource>
3232
<resource mime-type="text/rtf" kind="embedded" type="conclusion"><![CDATA[{\rtf1\ansi\ansicpg1252\cocoartf1038\cocoasubrtf360
3333
{\fonttbl\f0\fnil\fcharset0 LucidaGrande;}
3434
{\colortbl;\red255\green255\blue255;}
3535
\pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\ql\qnatural\pardirnatural
3636

3737
\f0\fs26 \cf0 Node.js was installed at\
3838
\
39-
/usr/local/bin/iojs\
40-
and symlinked at\
4139
/usr/local/bin/node\
4240
\
4341
npm was installed at\

0 commit comments

Comments
 (0)