Skip to content

Commit b18604b

Browse files
joaocgreisorangemocha
authored andcommitted
test: running tls-server-verify clients in parallel
OpenSSL s_client introduces some delay on Windows. With all clients running sequentially, this delay is big enough to break CI. This fix runs the clients in parallel (unless the test includes renegotiation), reducing the total run time. Fixes: #1461 PR-URL: #1836 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent f78c722 commit b18604b

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

test/parallel/test-tls-server-verify.js

+15-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,21 @@ function runTest(testIndex) {
307307
if (tcase.debug) {
308308
console.error('TLS server running on port ' + common.PORT);
309309
} else {
310-
runNextClient(0);
310+
if (tcase.renegotiate) {
311+
runNextClient(0);
312+
} else {
313+
var clientsCompleted = 0;
314+
for (var i = 0; i < tcase.clients.length; i++) {
315+
runClient(tcase.clients[i], function() {
316+
clientsCompleted++;
317+
if (clientsCompleted === tcase.clients.length) {
318+
server.close();
319+
successfulTests++;
320+
runTest(testIndex + 1);
321+
}
322+
});
323+
}
324+
}
311325
}
312326
});
313327
}

0 commit comments

Comments
 (0)