fix styles, cache LLNODE_DEBUG, tag variadic functions

Author: joyeecheung

src/llnode.cc

@@ -299,11 +299,24 @@ bool ListCmd::DoExecute(SBDebugger d, char** cmd,
   return true;
 }
 
+
+void InitDebugMode() {
+  bool isDebugMode = false;
+  char* var = getenv("LLNODE_DEBUG");
+  if (var != nullptr && strlen(var) != 0) {
+    isDebugMode = true;
+  }
+
+  v8::Error::SetDebugMode(isDebugMode);
+}
+
 }  // namespace llnode
 
 namespace lldb {
 
 bool PluginInitialize(SBDebugger d) {
+  llnode::InitDebugMode();
+
   SBCommandInterpreter interpreter = d.GetCommandInterpreter();
 
   SBCommand v8 = interpreter.AddMultiwordCommand("v8", "Node.js helpers");

src/llv8-constants.cc

@@ -89,8 +89,9 @@ static int64_t LookupConstant(SBTarget target, const char* name, int64_t def,
 int64_t Module::LoadRawConstant(const char* name, int64_t def) {
   Error err;
   int64_t v = LookupConstant(target_, name, def, err);
-  if (err.Fail())
+  if (err.Fail()) {
     Error::PrintInDebugMode("Failed to load raw constant %s", name);
+  }
 
   return v;
 }

src/llv8-inl.h

@@ -1,6 +1,7 @@
 #ifndef SRC_LLV8_INL_H_
 #define SRC_LLV8_INL_H_
 
+#include <cinttypes>
 #include "llv8.h"
 
 namespace llnode {
@@ -20,7 +21,7 @@ inline T LLV8::LoadValue(int64_t addr, Error& err) {
   T res = T(this, ptr);
   if (!res.Check()) {
     // TODO(joyeecheung): use Error::Failure() to report information when
-    // there is less noise from here
+    // there is less noise from here.
     err = Error(true, "Invalid value");
     return T();
   }

src/llv8.cc

@@ -58,9 +58,11 @@ void LLV8::Load(SBTarget target) {
   types.Assign(target, &common);
 }
 
+bool Error::isDebugMode = false;
+
 Error::Error(bool failed, const char* format, ...) {
   failed_ = failed;
-  char tmp[MSG_BUF_LENGTH];
+  char tmp[kMaxMessageLength];
   va_list arglist;
   va_start(arglist, format);
   vsnprintf(tmp, sizeof(tmp), format, arglist);
@@ -69,19 +71,11 @@ Error::Error(bool failed, const char* format, ...) {
 }
 
 
-bool IsDebugMode() {
-  char* var = getenv("LLNODE_DEBUG");
-  if (var == nullptr) return false;
-
-  return strlen(var) != 0;
-}
-
-
 void Error::PrintInDebugMode(const char* format, ...) {
-  if (!IsDebugMode()) {
+  if (!isDebugMode) {
     return;
   }
-  char fmt[MSG_BUF_LENGTH];
+  char fmt[kMaxMessageLength];
   snprintf(fmt, sizeof(fmt), "[llv8] %s\n", format);
   va_list arglist;
   va_start(arglist, format);
@@ -91,13 +85,13 @@ void Error::PrintInDebugMode(const char* format, ...) {
 
 
 Error Error::Failure(std::string msg) {
-  PrintInDebugMode(msg.c_str());
+  PrintInDebugMode("%s", msg.c_str());
   return Error(true, msg);
 }
 
 
 Error Error::Failure(const char* format, ...) {
-  char tmp[MSG_BUF_LENGTH];
+  char tmp[kMaxMessageLength];
   va_list arglist;
   va_start(arglist, format);
   vsnprintf(tmp, sizeof(tmp), format, arglist);
@@ -112,7 +106,7 @@ int64_t LLV8::LoadPtr(int64_t addr, Error& err) {
       process_.ReadPointerFromMemory(static_cast<addr_t>(addr), sberr);
   if (sberr.Fail()) {
     // TODO(joyeecheung): use Error::Failure() to report information when
-    // there is less noise from here
+    // there is less noise from here.
     err = Error(true, "Failed to load pointer from v8 memory");
     return -1;
   }
@@ -129,7 +123,7 @@ int64_t LLV8::LoadUnsigned(int64_t addr, uint32_t byte_size, Error& err) {
 
   if (sberr.Fail()) {
     // TODO(joyeecheung): use Error::Failure() to report information when
-    // there is less noise from here
+    // there is less noise from here.
     err = Error(true, "Failed to load unsigned from v8 memory");
     return -1;
   }

src/llv8.h

@@ -23,22 +23,28 @@ class Error {
  public:
   Error() : failed_(false), msg_("") {}
   Error(bool failed, std::string msg) : failed_(failed), msg_(msg) {}
-  Error(bool failed, const char* format, ...);
+  Error(bool failed, const char* format, ...)
+      __attribute__((format(printf, 3, 4)));
 
   static inline Error Ok() { return Error(false, "ok"); }
   static Error Failure(std::string msg);
-  static Error Failure(const char* format, ...);
-  static void PrintInDebugMode(const char* format, ...);
+  static Error Failure(const char* format, ...)
+      __attribute__((format(printf, 1, 2)));
+  static void PrintInDebugMode(const char* format, ...)
+      __attribute__((format(printf, 1, 2)));
 
   inline bool Success() const { return !Fail(); }
   inline bool Fail() const { return failed_; }
 
   inline const char* GetMessage() { return msg_.c_str(); }
 
+  static void SetDebugMode(bool mode) { isDebugMode = mode; }
+
  private:
   bool failed_;
   std::string msg_;
-  static const size_t MSG_BUF_LENGTH = 128;
+  static const size_t kMaxMessageLength = 128;
+  static bool isDebugMode;
 };
 
 #define V8_VALUE_DEFAULT_METHODS(NAME, PARENT)     \