-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the actual version of this? #25
Comments
Node-api C headers are always expected to be compatible when So this package always publishes with the latest node-api c headers. The package also contains a set of JS APIs to get node-api symbols. @nodejs/node-api I think the options for us would be:
I'm personally leaning towards option 1 and adding a note in the package README to explain the versioning rationale. |
Hi everybody, |
So, according to option 1, I'm using v0.0.5 for microsoft/vcpkg#29743 then. It won't be an issue to update to v1.0.0 once it gets published. Thank you for your detailed answers :) |
Thanks, I think we have a reasonable path forward now! |
I'd like to discuss about this in today meeting. |
In microsoft/vcpkg#29743 we are confused as to what version we should use when listing the contents of this repo.
Let's take an example:
0.0.5
8
19.8.1
See also: nodejs/node#46641 (comment)
NodeJS folks there seem to be suggesting "8" but if it would ever be distinguishable to a user for any reason to use a different upstream tag, that means the upstream tag needs to be in the version somehow...
The text was updated successfully, but these errors were encountered: