Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong symbols in v6.node_api_symbols #5

Closed
guentner opened this issue Dec 8, 2022 · 2 comments
Closed

Wrong symbols in v6.node_api_symbols #5

guentner opened this issue Dec 8, 2022 · 2 comments

Comments

@guentner
Copy link

guentner commented Dec 8, 2022

v6.node_api_symbols should probably extend v5.node_api_symbols instead of v5.js_native_api_symbols.

node-api-headers/symbols.js

Line 189 in d68505e

...v5.js_native_api_symbols

@NickNaso NickNaso mentioned this issue Dec 9, 2022
Merged
@NickNaso
Copy link
Member

NickNaso commented Dec 9, 2022

@guentner you are right I just made a PR to solve the problem. Thanks for reporting.

@legendecas
Copy link
Member

Fixed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NickNaso @legendecas @guentner