Skip to content

Commit 57b7df8

Browse files
authored
fix: repo/path mismatch in v8 update (#465)
1 parent fd566e2 commit 57b7df8

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

lib/update-v8/constants.js

+6-12
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ const zlibIgnore = `!/third_party/zlib
3434
exports.v8Deps = [
3535
{
3636
name: 'trace_event',
37-
repo: 'v8/base/trace_event/common',
38-
path: 'base/trace_event/common',
37+
repo: 'base/trace_event/common',
3938
gitignore: {
4039
match: '/base\n',
4140
replace: ''
@@ -44,8 +43,7 @@ exports.v8Deps = [
4443
},
4544
{
4645
name: 'gtest',
47-
repo: 'v8/testing/gtest',
48-
path: 'testing/gtest',
46+
repo: 'testing/gtest',
4947
gitignore: {
5048
match: '/testing/gtest',
5149
replace: gtestReplace
@@ -55,22 +53,19 @@ exports.v8Deps = [
5553
},
5654
{
5755
name: 'jinja2',
58-
repo: 'v8/third_party/jinja2',
59-
path: 'third_party/jinja2',
56+
repo: 'third_party/jinja2',
6057
gitignore: '!/third_party/jinja2',
6158
since: 56
6259
},
6360
{
6461
name: 'markupsafe',
65-
repo: 'v8/third_party/markupsafe',
66-
path: 'third_party/markupsafe',
62+
repo: 'third_party/markupsafe',
6763
gitignore: '!/third_party/markupsafe',
6864
since: 56
6965
},
7066
{
7167
name: 'googletest',
72-
repo: 'v8/third_party/googletest/src',
73-
path: 'third_party/googletest/src',
68+
repo: 'third_party/googletest/src',
7469
gitignore: {
7570
match: '/third_party/googletest/src',
7671
replace: googleTestReplace
@@ -79,8 +74,7 @@ exports.v8Deps = [
7974
},
8075
{
8176
name: 'zlib',
82-
repo: 'v8/third_party/zlib',
83-
path: 'third_party/zlib',
77+
repo: 'third_party/zlib',
8478
gitignore: zlibIgnore,
8579
since: 80
8680
}

lib/update-v8/majorUpdate.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ function updateV8Deps() {
113113
}
114114
}
115115
const [repo, commit] = await readDeps(ctx.nodeDir, dep.repo);
116-
const thePath = path.join(ctx.nodeDir, 'deps/v8', dep.path);
116+
const thePath = path.join(ctx.nodeDir, 'deps/v8', dep.repo);
117117
await fetchFromGit(thePath, repo, commit);
118118
}
119119
/* eslint-enable */

0 commit comments

Comments
 (0)