fixup! ncu-ci: command to start CI for PRs

mmarchini · mmarchini · commit 9f1badebe856 · 2020-07-09T10:18:18.000-07:00
diff --git a/bin/ncu-ci b/bin/ncu-ci
@@ -208,15 +208,12 @@ class RunPRJobCommand {
       validArgs = false;
     }
     if (!validArgs) {
-      // TODO(mmarchini): change to our API once #443 lands
-      // this.cli.setExitCode(1);
-      process.exitCode = 1;
+      this.cli.setExitCode(1);
       return;
     }
     const jobRunner = new RunPRJob(cli, request, owner, repo, prid);
     if (!jobRunner.start()) {
-      // TODO(mmarchini): change to our API once #443 lands
-      // this.cli.setExitCode(1);
+      this.cli.setExitCode(1);
       process.exitCode = 1;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -208,15 +208,12 @@ class RunPRJobCommand {`
`208`	`208`	`validArgs = false;`
`209`	`209`	`}`
`210`	`210`	`if (!validArgs) {`
`211`		`- // TODO(mmarchini): change to our API once #443 lands`
`212`		`- // this.cli.setExitCode(1);`
`213`		`- process.exitCode = 1;`
	`211`	`+ this.cli.setExitCode(1);`
`214`	`212`	`return;`
`215`	`213`	`}`
`216`	`214`	`const jobRunner = new RunPRJob(cli, request, owner, repo, prid);`
`217`	`215`	`if (!jobRunner.start()) {`
`218`		`- // TODO(mmarchini): change to our API once #443 lands`
`219`		`- // this.cli.setExitCode(1);`
	`216`	`+ this.cli.setExitCode(1);`
`220`	`217`	`process.exitCode = 1;`
`221`	`218`	`}`
`222`	`219`	`}`