Skip to content

Commit b30988a

Browse files
authored
fix(v8): remove trace_event starting with 12.6 (#807)
Also add a custom error message when a dependency disappears to avoid the unhelpful `Cannot read properties of undefined (reading 'split')`. Refs: v8/v8@f8fa220
1 parent 39f1002 commit b30988a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/update-v8/constants.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ export const v8Deps = [
4646
match: '/base\n',
4747
replace: ''
4848
},
49-
since: 55
49+
since: 55,
50+
until: 125
5051
},
5152
{
5253
name: 'gtest',

lib/update-v8/majorUpdate.js

+3
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,9 @@ async function readDeps(nodeDir, depName) {
146146
let deps;
147147
eval(depsDeclaration); // eslint-disable-line no-eval
148148
const dep = deps[depName];
149+
if (!dep) {
150+
throw new Error(`V8 dep "${depName}" not found in DEPS file`);
151+
}
149152
if (typeof dep === 'object') {
150153
return dep.url.split('@');
151154
}

0 commit comments

Comments
 (0)