Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect double Refs and Fixes entries. #133

Closed
BridgeAR opened this issue Dec 12, 2017 · 5 comments · Fixed by #478
Closed

Detect double Refs and Fixes entries. #133

BridgeAR opened this issue Dec 12, 2017 · 5 comments · Fixed by #478
Labels
feature request New features for node-core-utils git-node

Comments

@BridgeAR
Copy link
Member

Right now if the tool is used as it the commit message that is generated duplicates Refs and Fixes entries by amending those blindly. We might come up with a way to remove those - and verify that they are identical with the ones being amended (and if not, it should result in an error).

@joyeecheung joyeecheung added the feature request New features for node-core-utils label Dec 18, 2017
@joyeecheung
Copy link
Member

BTW https://github.com/nodejs/node-core-utils/pull/106/files#diff-806602ca40b9756be13878981c68b536R109 does handle this in case there are already urls present in the commit message without metadata.

@joyeecheung
Copy link
Member

It's fixed by the new git-node command, although it still does not fix the following case:

Fixes: #XXXX   # put by the author

Something something...

Fixes: https://github.com/nodejs/node/issue/XXXX # generated by us

@BridgeAR
Copy link
Member Author

@joyeecheung that was the case that I meant ^^.

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@codebytere
Copy link
Member

Will be closed by #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features for node-core-utils git-node
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants