Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a collaborator's contact to a message by login #140

Closed
joyeecheung opened this issue Jan 15, 2018 · 3 comments
Closed

Add a collaborator's contact to a message by login #140

joyeecheung opened this issue Jan 15, 2018 · 3 comments
Labels
enhancement Things that enhances functionality, provided by node-core-utils feature request New features for node-core-utils new tool New tool that could be added to node-core-utils stale

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Jan 15, 2018

There are cases where one has to add a collaborator manually to the metadata since our heuristics are limited. It's worth adding a command or something that allows the users to add a collaborator there by specifying a login. Maybe something like

get-metadata -i msg.txt --add joyeecheung -f msg.txt
@tniessen
Copy link
Member

When's that necessary? Shouldn't reviews be properly resolved using the GH API already?

@joyeecheung
Copy link
Member Author

@tniessen For example when the LGTM is given via emails nodejs/node#18125 (comment) . That can be fixed differently, of course, but I think we will keep bumping into edge cases like this so it's nice to have a command for adding reviewers.

@joyeecheung joyeecheung added the feature request New features for node-core-utils label Jan 17, 2018
@priyank-p priyank-p added the enhancement Things that enhances functionality, provided by node-core-utils label Jan 18, 2018
@joyeecheung joyeecheung added the new tool New tool that could be added to node-core-utils label Jan 18, 2018
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Things that enhances functionality, provided by node-core-utils feature request New features for node-core-utils new tool New tool that could be added to node-core-utils stale
Projects
None yet
Development

No branches or pull requests

3 participants