Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-node): allow security release promotion #900

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 21, 2025

In order to promote a security release using this script:

  • your local HEAD should be the release proposal commit
  • ncu config upstream should point to the public repo (NOT the private one)

N.B.: At the end of the process, it won't tell you to push to the private repo, until you do that manually the release proposal won't auto-close.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.08%. Comparing base (cce9b81) to head (e7573e6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          39       39           
  Lines        4676     4676           
=======================================
  Hits         3745     3745           
  Misses        931      931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 4a03216 into nodejs:main Mar 20, 2025
13 checks passed
@aduh95 aduh95 deleted the release-promote-security branch March 20, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants