feat: Properly fail with invalid host:port

Author: Jan Krems

Diff for: lib/node-inspect.js

@@ -123,11 +123,13 @@ class NodeInspector {
       const attemptConnect = () => {
         ++connectionAttempts;
         this.stdout.write('.');
-        this.client.connect()
-          .then(null, () => {
+        return this.client.connect()
+          .then(() => {
+            this.stdout.write(' done');
+          }, () => {
             // If it's failed to connect 10 times then print failed message
             if (connectionAttempts >= 10) {
-              this.print(' failed to connect, please retry');
+              this.stdout.write(' failed to connect, please retry\n');
               process.exit(1);
             }
             return delay(500).then(() => attemptConnect());

Diff for: test/cli/invalid-args.test.js

@@ -0,0 +1,23 @@
+'use strict';
+const tap = require('tap');
+
+const startCLI = require('./start-cli');
+
+tap.test('launch CLI w/o args', (t) => {
+  const cli = startCLI([]);
+  return cli.quit()
+    .then((code) => {
+      t.equal(code, 1, 'exits with non-zero exit code');
+      t.match(cli.output, /^Usage:/, 'Prints usage info');
+    });
+});
+
+tap.test('launch w/ invalid host:port', (t) => {
+  const cli = startCLI(['localhost:914']);
+  return cli.quit()
+    .then((code) => {
+      t.match(cli.output, 'failed to connect',
+        'Tells the user that the connection failed');
+      t.equal(code, 1, 'exits with non-zero exit code');
+    });
+});