Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

No way to respond to the HTTP upgrade request #3189

Closed
mmalecki opened this issue Apr 29, 2012 · 1 comment
Closed

No way to respond to the HTTP upgrade request #3189

mmalecki opened this issue Apr 29, 2012 · 1 comment
Labels
http

Comments

@mmalecki
Copy link

When there's an incoming HTTP request with Upgrade header, node intercepts it, leaving no way to respond to it like it was a regular HTTP request. WebSocket spec says to respond with meaningful HTTP codes when upgrade is not possible. There's likely an API missing (or needing to be changed) on the node side.

I realize I can just write to a socket, but it's a workaround.
@koichik
Copy link

koichik commented May 2, 2012

This will fix by #3036 in v0.9. Closing.

@koichik koichik closed this as completed May 2, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
http
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koichik @mmalecki