Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Transform stream can emit 'finish' before _flush() callback has been called. #8281

Closed
kanongil opened this issue Aug 28, 2014 · 2 comments
Closed
Labels

Comments

@kanongil
Copy link

Looking at the implementation for the Transform stream, I noticed that any async callback usage in a _flush() implementation will cause the finish event to be emitted before the data has been flushed.

As far as I can tell this behavior breaks the API regarding the finish event. Ie. some data might not have been flushed yet.

@vkurchatkin
Copy link

duplicate of #7612

@kanongil
Copy link
Author

I see I missed the note in the transform section, explaining the exact relation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants