Skip to content

Commit 3bf8eb3

Browse files
refacknodejs-ci
authored andcommitted
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: nodejs/node#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
1 parent b03e009 commit 3bf8eb3

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
# Reset this number to 0 on major V8 upgrades.
4141
# Increment by one for each non-official patch applied to deps/v8.
42-
'v8_embedder_string': '-node.6',
42+
'v8_embedder_string': '-node.7',
4343

4444
##### V8 defaults for Node.js #####
4545

deps/v8/src/builtins/setup-builtins-internal.cc

+9
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,10 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index,
275275

276276
} // namespace
277277

278+
#ifdef _MSC_VER
279+
#pragma optimize( "", off )
280+
#endif
281+
278282
// static
279283
void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
280284
Builtins* builtins = isolate->builtins();
@@ -351,5 +355,10 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
351355
builtins->MarkInitialized();
352356
}
353357

358+
#ifdef _MSC_VER
359+
#pragma optimize( "", on )
360+
#endif
361+
362+
354363
} // namespace internal
355364
} // namespace v8

0 commit comments

Comments
 (0)