Skip to content

Commit 4d3ac39

Browse files
refacknodejs-ci
authored andcommitted
deps, v8: fix build torque on windows
On windows the torque binary needs to be compiled and linked with exception semantics and assume V8 is embedded Fixes: #57
1 parent fcd54a9 commit 4d3ac39

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

deps/v8/gypfiles/v8.gyp

+23
Original file line numberDiff line numberDiff line change
@@ -2526,10 +2526,33 @@
25262526
'GCC_ENABLE_CPP_RTTI': 'YES', # -frtti
25272527
},
25282528
'defines': ['ANTLR4CPP_STATIC'],
2529+
'defines!': [
2530+
'_HAS_EXCEPTIONS=0',
2531+
'BUILDING_V8_SHARED=1',
2532+
],
25292533
'include_dirs': [
25302534
'../third_party/antlr4/runtime/Cpp/runtime/src',
25312535
'../src/torque',
25322536
],
2537+
# This is defined trough `configurations` for GYP+ninja compatibility
2538+
'configurations': {
2539+
'Debug': {
2540+
'msvs_settings': {
2541+
'VCCLCompilerTool': {
2542+
'RuntimeTypeInfo': 'true',
2543+
'ExceptionHandling': 1,
2544+
},
2545+
}
2546+
},
2547+
'Release': {
2548+
'msvs_settings': {
2549+
'VCCLCompilerTool': {
2550+
'RuntimeTypeInfo': 'true',
2551+
'ExceptionHandling': 1,
2552+
},
2553+
}
2554+
},
2555+
},
25332556
'sources': [
25342557
'../src/torque/TorqueBaseVisitor.cpp',
25352558
'../src/torque/TorqueBaseVisitor.h',

0 commit comments

Comments
 (0)